You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Zhou-lemon (via GitHub)" <gi...@apache.org> on 2025/11/14 09:20:10 UTC

[PR] [feat](metadata) Add system table information.database_properties [doris]

Zhou-lemon opened a new pull request, #58034:
URL: https://github.com/apache/doris/pull/58034

   ### What problem does this PR solve?
   
   Issue Number: #57704 
   
   Related PR: 
   
   Problem Summary:
   
   
   ### Release note
   
   `select * from information_schema.database_properties;
   `
   +--------------+-----------------------------+-----------------+----------------+
   | CATALOG_NAME | SCHEMA_NAME                 | PROPERTY_NAME   | PROPERTY_VALUE |
   +--------------+-----------------------------+-----------------+----------------+
   | internal     | information_schema          |                 |                |
   | internal     | test_database_properties_db | compression     | lz4            |
   | internal     | test_database_properties_db | replication_num | 1              |
   +--------------+-----------------------------+-----------------+----------------+
   
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3531750031

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540408313

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 34215 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 77ec0e07dffc0efe4c22a9546a7915368a7b4da4, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17649	5157	5026	5026
   q2	2025	326	204	204
   q3	10174	1324	712	712
   q4	10222	894	362	362
   q5	7526	2466	2280	2280
   q6	181	166	135	135
   q7	906	774	634	634
   q8	9342	1435	1140	1140
   q9	7331	5108	5246	5108
   q10	6893	2214	1821	1821
   q11	515	305	291	291
   q12	367	370	227	227
   q13	17759	3651	3023	3023
   q14	234	226	216	216
   q15	568	509	509	509
   q16	1035	999	952	952
   q17	614	887	383	383
   q18	7703	7094	7118	7094
   q19	1097	943	561	561
   q20	379	358	234	234
   q21	4003	3180	2316	2316
   q22	1058	1040	987	987
   Total cold run time: 107581 ms
   Total hot run time: 34215 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5181	5087	5089	5087
   q2	252	329	230	230
   q3	2193	2671	2266	2266
   q4	1377	1789	1321	1321
   q5	4181	4409	4537	4409
   q6	226	174	135	135
   q7	2025	2033	1805	1805
   q8	2720	2675	2613	2613
   q9	7443	7320	7395	7320
   q10	3018	3257	2806	2806
   q11	598	525	524	524
   q12	683	777	604	604
   q13	3520	3935	3297	3297
   q14	295	291	283	283
   q15	539	493	500	493
   q16	1089	1110	1301	1110
   q17	1158	1583	1383	1383
   q18	7743	7787	7511	7511
   q19	811	995	1010	995
   q20	1973	2035	1887	1887
   q21	4925	4342	4290	4290
   q22	1070	1058	1015	1015
   Total cold run time: 53020 ms
   Total hot run time: 51384 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3533172187

   # FE Regression Coverage Report
   Increment line coverage `  63.64% (49/77)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_990f0f07af534d10c25c844c3db0a49149c5aaf4_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_990f0f07af534d10c25c844c3db0a49149c5aaf4_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540463078

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.45 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 77ec0e07dffc0efe4c22a9546a7915368a7b4da4, data reload: false
   
   query1	0.04	0.04	0.04
   query2	0.12	0.07	0.07
   query3	0.31	0.07	0.07
   query4	1.62	0.09	0.09
   query5	0.26	0.25	0.25
   query6	1.17	0.65	0.65
   query7	0.02	0.02	0.02
   query8	0.07	0.06	0.06
   query9	0.64	0.51	0.53
   query10	0.61	0.58	0.57
   query11	0.26	0.13	0.14
   query12	0.25	0.14	0.15
   query13	0.64	0.63	0.63
   query14	1.04	1.02	1.02
   query15	0.94	0.88	0.86
   query16	0.39	0.39	0.40
   query17	1.02	1.05	1.05
   query18	0.24	0.22	0.23
   query19	2.00	1.82	1.86
   query20	0.02	0.02	0.02
   query21	15.39	0.29	0.25
   query22	4.97	0.11	0.09
   query23	15.39	0.38	0.23
   query24	2.60	0.55	0.35
   query25	0.09	0.09	0.09
   query26	0.19	0.18	0.18
   query27	0.09	0.10	0.09
   query28	3.52	1.27	1.10
   query29	12.56	3.96	3.33
   query30	0.33	0.12	0.09
   query31	2.82	0.62	0.45
   query32	3.24	0.61	0.52
   query33	3.09	3.14	3.16
   query34	15.98	5.14	4.43
   query35	4.54	4.52	4.47
   query36	0.63	0.52	0.50
   query37	0.22	0.09	0.09
   query38	0.19	0.05	0.06
   query39	0.05	0.05	0.05
   query40	0.21	0.18	0.18
   query41	0.11	0.06	0.06
   query42	0.08	0.05	0.04
   query43	0.06	0.06	0.06
   Total cold run time: 98.01 s
   Total hot run time: 28.45 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540075096

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #58034:
URL: https://github.com/apache/doris/pull/58034#discussion_r2544205609


##########
be/src/exec/schema_scanner/schema_database_properties_scanner.h:
##########
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+#include <gen_cpp/FrontendService_types.h>
+
+#include <vector>
+
+#include "common/status.h"
+#include "exec/schema_scanner.h"
+
+namespace doris {
+class RuntimeState;
+namespace vectorized {
+class Block;
+}
+
+class SchemaDatabasePropertiesScanner : public SchemaScanner {
+    ENABLE_FACTORY_CREATOR(SchemaDatabasePropertiesScanner);
+
+public:
+    SchemaDatabasePropertiesScanner();
+    ~SchemaDatabasePropertiesScanner() override = default;
+
+    Status start(RuntimeState* state) override;
+    Status get_next_block_internal(vectorized::Block* block, bool* eos) override;
+
+    static std::vector<SchemaScanner::ColumnDesc> _s_tbls_columns;
+
+private:
+    Status get_onedb_info_from_fe(int64_t dbId);
+    bool check_and_mark_eos(bool* eos) const;
+    int _block_rows_limit = 4096;
+    int _row_idx = 0;
+    int _total_rows = 0;
+    int _db_index = 0;
+    TGetDbsResult _db_result;
+    std::unique_ptr<vectorized::Block> _dbproperties_block = nullptr;
+    int _rpc_timeout_ms = 3000;
+};
+} // namespace doris

Review Comment:
   The namespace closing should include a semicolon to match the project's code style convention. Most other scanner header files in the same directory use `}; // namespace doris` (with semicolon). For consistency with files like schema_table_properties_scanner.h, schema_active_queries_scanner.h, and others, this should be `}; // namespace doris`.
   ```suggestion
   }; // namespace doris
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #58034:
URL: https://github.com/apache/doris/pull/58034


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3541114241

   run external


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532107617

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/990f0f07af534d10c25c844c3db0a49149c5aaf4_990f0f07af534d10c25c844c3db0a49149c5aaf4_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/990f0f07af534d10c25c844c3db0a49149c5aaf4_990f0f07af534d10c25c844c3db0a49149c5aaf4_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 80.56% (1683/2089) |
   | Line Coverage     | 66.70% (29691/44515) |
   | Region Coverage   | 67.30% (14823/22026) |
   | Branch Coverage   | 57.52% (7883/13704) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3544222875

   > > I doubt that the compression property on databases does not work, please add a case to check it.
   > 
   > I've verified that it indeed doesn't work — the table's compression algorithm is only derived from table-level properties or the global default configuration. I'll modify the test cases.
   
   I think we can remove the compression property from database.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3569182234

   # BE Regression && UT Coverage Report
   Increment line coverage `86.61% (97/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.53% (24394/34105) |
   | Line Coverage     | 57.97% (253462/437242) |
   | Region Coverage   | 53.13% (210963/397056) |
   | Branch Coverage   | 54.56% (90126/165195) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540223992

   # FE UT Coverage Report
   Increment line coverage `  16.88% (13/77)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540445003

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 188686 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 77ec0e07dffc0efe4c22a9546a7915368a7b4da4, data reload: false
   
   query1	1052	404	416	404
   query2	6599	1684	1693	1684
   query3	6751	233	228	228
   query4	26547	23171	23083	23083
   query5	4440	653	546	546
   query6	370	252	232	232
   query7	4652	499	303	303
   query8	310	258	251	251
   query9	8687	2906	2911	2906
   query10	508	359	314	314
   query11	15379	15013	14759	14759
   query12	187	133	129	129
   query13	1678	580	463	463
   query14	10294	9172	9318	9172
   query15	208	193	169	169
   query16	7322	676	528	528
   query17	1271	785	650	650
   query18	2011	441	348	348
   query19	209	207	191	191
   query20	138	128	127	127
   query21	220	132	116	116
   query22	4083	4047	3986	3986
   query23	33940	33102	32806	32806
   query24	8272	2366	2361	2361
   query25	631	547	456	456
   query26	1260	279	166	166
   query27	2739	502	365	365
   query28	4406	2274	2244	2244
   query29	872	608	560	560
   query30	303	226	198	198
   query31	900	816	719	719
   query32	92	92	79	79
   query33	604	399	353	353
   query34	786	846	524	524
   query35	809	822	754	754
   query36	971	989	887	887
   query37	134	122	99	99
   query38	3547	3491	3414	3414
   query39	1522	1419	1399	1399
   query40	236	141	125	125
   query41	64	60	60	60
   query42	134	117	116	116
   query43	466	495	455	455
   query44	1261	816	789	789
   query45	183	181	173	173
   query46	884	989	649	649
   query47	1775	1813	1789	1789
   query48	410	425	324	324
   query49	769	486	405	405
   query50	647	678	412	412
   query51	3990	3891	3983	3891
   query52	120	116	106	106
   query53	256	280	208	208
   query54	345	319	304	304
   query55	98	94	90	90
   query56	364	339	344	339
   query57	1188	1189	1113	1113
   query58	300	283	290	283
   query59	2440	2657	2552	2552
   query60	366	367	349	349
   query61	166	160	163	160
   query62	801	736	652	652
   query63	240	196	204	196
   query64	4625	1191	949	949
   query65	4025	3928	3940	3928
   query66	1219	460	400	400
   query67	15541	15129	14828	14828
   query68	8205	949	635	635
   query69	528	346	290	290
   query70	1341	1267	1315	1267
   query71	442	375	318	318
   query72	5878	4966	4858	4858
   query73	677	577	367	367
   query74	9160	9027	9061	9027
   query75	3289	3256	2747	2747
   query76	3212	1167	755	755
   query77	506	417	353	353
   query78	9621	9867	8916	8916
   query79	1146	862	612	612
   query80	713	625	552	552
   query81	521	256	225	225
   query82	436	170	152	152
   query83	271	269	253	253
   query84	256	110	95	95
   query85	875	512	460	460
   query86	334	304	296	296
   query87	3713	3747	3668	3668
   query88	2911	2298	2288	2288
   query89	394	339	297	297
   query90	1800	248	241	241
   query91	183	183	160	160
   query92	82	80	78	78
   query93	1137	1057	690	690
   query94	698	459	365	365
   query95	451	362	366	362
   query96	492	600	288	288
   query97	2901	2981	2885	2885
   query98	238	232	227	227
   query99	1337	1389	1341	1341
   Total cold run time: 271365 ms
   Total hot run time: 188686 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540060360

   > I doubt that the compression property on databases does not work, please add a case to check it.
   
   I've verified that it indeed doesn't work — the table's compression algorithm is only derived from table-level properties or the global default configuration. I'll modify the test cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540939682

   # BE Regression && UT Coverage Report
   Increment line coverage `84.82% (95/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.48% (24339/34049) |
   | Line Coverage     | 57.97% (253037/436509) |
   | Region Coverage   | 53.04% (210029/395974) |
   | Branch Coverage   | 54.54% (89936/164893) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568858174

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.32 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit abbe9f201e45558f044c8588742f73023282f4f7, data reload: false
   
   query1	0.06	0.05	0.05
   query2	0.12	0.07	0.07
   query3	0.32	0.07	0.07
   query4	1.63	0.09	0.09
   query5	0.27	0.25	0.24
   query6	1.17	0.65	0.65
   query7	0.03	0.02	0.03
   query8	0.08	0.06	0.06
   query9	0.63	0.54	0.53
   query10	0.57	0.59	0.58
   query11	0.25	0.13	0.13
   query12	0.25	0.14	0.14
   query13	0.64	0.62	0.62
   query14	1.02	1.02	1.01
   query15	0.94	0.85	0.87
   query16	0.39	0.38	0.39
   query17	1.03	1.04	1.00
   query18	0.22	0.22	0.21
   query19	2.00	1.82	1.85
   query20	0.02	0.01	0.02
   query21	15.40	0.27	0.24
   query22	5.00	0.10	0.10
   query23	15.40	0.38	0.23
   query24	2.86	0.51	0.32
   query25	0.09	0.09	0.10
   query26	0.19	0.18	0.18
   query27	0.09	0.09	0.09
   query28	3.67	1.24	1.08
   query29	12.53	4.04	3.31
   query30	0.34	0.13	0.11
   query31	2.83	0.62	0.46
   query32	3.24	0.60	0.50
   query33	3.13	3.03	3.13
   query34	16.54	5.21	4.49
   query35	4.49	4.53	4.59
   query36	0.64	0.52	0.51
   query37	0.22	0.09	0.09
   query38	0.20	0.05	0.05
   query39	0.06	0.05	0.05
   query40	0.19	0.17	0.17
   query41	0.11	0.06	0.06
   query42	0.07	0.05	0.05
   query43	0.06	0.06	0.05
   Total cold run time: 98.99 s
   Total hot run time: 28.32 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532004055

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532440673

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 34238 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 990f0f07af534d10c25c844c3db0a49149c5aaf4, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17680	5215	5033	5033
   q2	2017	336	203	203
   q3	10185	1327	705	705
   q4	10226	885	375	375
   q5	7504	2349	2351	2349
   q6	189	166	137	137
   q7	892	770	622	622
   q8	9360	1372	1092	1092
   q9	7163	5214	5195	5195
   q10	6893	2250	1814	1814
   q11	492	304	272	272
   q12	373	365	231	231
   q13	17817	3681	3059	3059
   q14	231	240	207	207
   q15	577	524	499	499
   q16	988	997	930	930
   q17	594	878	373	373
   q18	7839	7061	7047	7047
   q19	1098	955	565	565
   q20	367	363	226	226
   q21	3871	3199	2301	2301
   q22	1102	1081	1003	1003
   Total cold run time: 107458 ms
   Total hot run time: 34238 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5203	5172	5120	5120
   q2	258	320	231	231
   q3	2201	2701	2321	2321
   q4	1377	1778	1328	1328
   q5	4211	4637	4600	4600
   q6	223	210	136	136
   q7	2057	2124	1835	1835
   q8	2623	2547	2519	2519
   q9	7354	7578	7121	7121
   q10	3117	3316	2838	2838
   q11	593	545	515	515
   q12	742	824	640	640
   q13	3630	3954	3296	3296
   q14	282	303	266	266
   q15	544	509	541	509
   q16	1101	1117	1057	1057
   q17	1225	1628	1411	1411
   q18	8055	7643	7578	7578
   q19	837	880	1033	880
   q20	2091	2094	1923	1923
   q21	5069	4551	4348	4348
   q22	1073	1045	1015	1015
   Total cold run time: 53866 ms
   Total hot run time: 51487 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568746405

   # FE UT Coverage Report
   Increment line coverage `  20.31% (13/64)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568637879

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532496566

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.42 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 990f0f07af534d10c25c844c3db0a49149c5aaf4, data reload: false
   
   query1	0.05	0.04	0.05
   query2	0.09	0.05	0.06
   query3	0.26	0.08	0.09
   query4	1.60	0.11	0.11
   query5	0.26	0.26	0.25
   query6	1.20	0.64	0.65
   query7	0.02	0.02	0.03
   query8	0.05	0.04	0.05
   query9	0.58	0.52	0.52
   query10	0.58	0.57	0.57
   query11	0.17	0.11	0.12
   query12	0.15	0.11	0.12
   query13	0.62	0.60	0.60
   query14	1.00	1.01	0.99
   query15	0.84	0.83	0.83
   query16	0.39	0.40	0.40
   query17	1.01	1.04	1.01
   query18	0.21	0.20	0.20
   query19	1.90	1.74	1.78
   query20	0.02	0.01	0.01
   query21	15.44	0.21	0.13
   query22	4.80	0.07	0.05
   query23	15.66	0.26	0.10
   query24	2.94	0.55	0.43
   query25	0.08	0.06	0.06
   query26	0.15	0.13	0.14
   query27	0.09	0.07	0.06
   query28	3.86	1.15	0.93
   query29	12.60	3.82	3.21
   query30	0.29	0.13	0.13
   query31	2.82	0.58	0.38
   query32	3.23	0.56	0.46
   query33	3.03	3.04	3.05
   query34	15.78	5.17	4.52
   query35	4.63	4.55	5.07
   query36	0.70	0.56	0.56
   query37	0.12	0.07	0.07
   query38	0.07	0.04	0.05
   query39	0.04	0.03	0.02
   query40	0.18	0.15	0.14
   query41	0.09	0.03	0.03
   query42	0.04	0.03	0.04
   query43	0.06	0.03	0.03
   Total cold run time: 97.7 s
   Total hot run time: 27.42 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3534066251

   I doubt that the compression property on databases does not work, please add a case to check it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540152467

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/77ec0e07dffc0efe4c22a9546a7915368a7b4da4_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/77ec0e07dffc0efe4c22a9546a7915368a7b4da4_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 80.56% (1683/2089) |
   | Line Coverage     | 66.71% (29698/44518) |
   | Region Coverage   | 67.26% (14816/22028) |
   | Branch Coverage   | 57.50% (7881/13706) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #58034:
URL: https://github.com/apache/doris/pull/58034#discussion_r2552596717


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -1565,6 +1578,81 @@ private static TFetchSchemaTableDataResult tablePropertiesMetadataResult(TSchema
         return result;
     }
 
+    private static TFetchSchemaTableDataResult databasePropertiesMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        if (!params.isSetDbId()) {
+            return errorResult("current db id is not set.");
+        }
+        if (!params.isSetCatalog()) {
+            return errorResult("current catalog is not set.");
+        }
+
+        TUserIdentity tcurrentUserIdentity = params.getCurrentUserIdent();
+        UserIdentity currentUserIdentity = UserIdentity.fromThrift(tcurrentUserIdentity);
+        TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+        Long dbId = params.getDbId();
+        String clg = params.getCatalog();
+        List<TRow> dataBatch = Lists.newArrayList();
+        CatalogIf catalog = Env.getCurrentEnv().getCatalogMgr().getCatalog(clg);
+        if (catalog == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+        DatabaseIf databaseIf = catalog.getDbNullable(dbId);
+        if (databaseIf == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+
+        if (catalog instanceof InternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),

Review Comment:
   We can move this auth check outside the `if` block.
   Same suggestion for `else` block



##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -1565,6 +1578,81 @@ private static TFetchSchemaTableDataResult tablePropertiesMetadataResult(TSchema
         return result;
     }
 
+    private static TFetchSchemaTableDataResult databasePropertiesMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        if (!params.isSetDbId()) {
+            return errorResult("current db id is not set.");
+        }
+        if (!params.isSetCatalog()) {
+            return errorResult("current catalog is not set.");
+        }
+
+        TUserIdentity tcurrentUserIdentity = params.getCurrentUserIdent();
+        UserIdentity currentUserIdentity = UserIdentity.fromThrift(tcurrentUserIdentity);
+        TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+        Long dbId = params.getDbId();
+        String clg = params.getCatalog();
+        List<TRow> dataBatch = Lists.newArrayList();
+        CatalogIf catalog = Env.getCurrentEnv().getCatalogMgr().getCatalog(clg);
+        if (catalog == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+        DatabaseIf databaseIf = catalog.getDbNullable(dbId);
+        if (databaseIf == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+
+        if (catalog instanceof InternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),
+                    databaseIf.getFullName(), PrivPredicate.SHOW)) {
+                result.setDataBatch(dataBatch);
+                result.setStatus(new TStatus(TStatusCode.OK));
+                return result;
+            }
+            Database db = (Database) databaseIf;
+            Map<String, String> props = db.getDbProperties().getProperties();
+            if (props == null || props.isEmpty()) {
+                TRow trow = new TRow();
+                trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+                trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+                trow.addToColumnValue(new TCell().setStringVal(""));
+                trow.addToColumnValue(new TCell().setStringVal(""));
+                dataBatch.add(trow);
+            } else {
+                props.forEach((key, value) -> {
+                    TRow trow = new TRow();
+                    trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+                    trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+                    trow.addToColumnValue(new TCell().setStringVal(key));
+                    trow.addToColumnValue(new TCell().setStringVal(value));
+                    dataBatch.add(trow);
+                });
+            }
+        } else if (catalog instanceof ExternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),
+                    databaseIf.getFullName(), PrivPredicate.SHOW)) {
+                result.setDataBatch(dataBatch);
+                result.setStatus(new TStatus(TStatusCode.OK));
+                return result;
+            }
+            TRow trow = new TRow();
+            trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+            trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+            trow.addToColumnValue(new TCell().setStringVal(""));

Review Comment:
   The ExternalDatabase also has a `databaseProperty` member. Although it is not used currenlty, but I think we should add it here now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568850279

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 187873 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit abbe9f201e45558f044c8588742f73023282f4f7, data reload: false
   
   query1	1026	414	424	414
   query2	6560	1663	1671	1663
   query3	6755	221	228	221
   query4	25933	23245	22653	22653
   query5	4413	633	493	493
   query6	333	244	230	230
   query7	4637	505	316	316
   query8	302	255	248	248
   query9	8715	2569	2588	2569
   query10	494	334	300	300
   query11	15617	15169	15210	15169
   query12	190	122	115	115
   query13	1705	592	460	460
   query14	10339	9295	9252	9252
   query15	208	199	171	171
   query16	7330	705	565	565
   query17	1234	756	602	602
   query18	1982	416	322	322
   query19	206	205	178	178
   query20	128	119	120	119
   query21	217	141	113	113
   query22	4168	4105	4078	4078
   query23	33723	32945	32935	32935
   query24	8448	2404	2437	2404
   query25	601	533	460	460
   query26	1232	274	169	169
   query27	2742	504	359	359
   query28	4382	2180	2155	2155
   query29	849	642	495	495
   query30	306	234	196	196
   query31	923	810	716	716
   query32	86	73	73	73
   query33	601	393	337	337
   query34	799	872	522	522
   query35	825	821	734	734
   query36	954	982	905	905
   query37	126	106	90	90
   query38	3542	3531	3493	3493
   query39	1478	1433	1399	1399
   query40	243	135	121	121
   query41	66	61	63	61
   query42	124	111	112	111
   query43	495	511	463	463
   query44	1285	790	765	765
   query45	182	174	173	173
   query46	886	1003	645	645
   query47	1725	1757	1753	1753
   query48	388	446	323	323
   query49	777	479	400	400
   query50	701	698	410	410
   query51	3891	3984	3925	3925
   query52	119	115	102	102
   query53	238	265	198	198
   query54	309	306	286	286
   query55	93	87	82	82
   query56	336	324	328	324
   query57	1178	1167	1111	1111
   query58	300	267	278	267
   query59	2502	2536	2479	2479
   query60	354	334	323	323
   query61	190	157	156	156
   query62	793	731	675	675
   query63	229	197	199	197
   query64	4546	1152	870	870
   query65	4053	3926	3962	3926
   query66	1155	430	350	350
   query67	15303	15171	14890	14890
   query68	3684	994	656	656
   query69	500	328	288	288
   query70	1382	1234	1271	1234
   query71	419	352	302	302
   query72	6090	5256	5187	5187
   query73	666	634	373	373
   query74	8966	9018	8813	8813
   query75	3334	3371	2845	2845
   query76	3280	1155	733	733
   query77	510	416	339	339
   query78	9588	9770	8881	8881
   query79	2042	856	637	637
   query80	1692	668	506	506
   query81	574	257	223	223
   query82	401	161	139	139
   query83	360	266	245	245
   query84	262	107	90	90
   query85	911	474	450	450
   query86	459	297	305	297
   query87	3693	3700	3639	3639
   query88	2839	2253	2196	2196
   query89	382	325	297	297
   query90	1801	238	229	229
   query91	165	165	148	148
   query92	77	73	67	67
   query93	1334	991	685	685
   query94	722	450	342	342
   query95	405	328	316	316
   query96	483	580	277	277
   query97	2887	2962	2887	2887
   query98	232	213	216	213
   query99	1288	1411	1260	1260
   Total cold run time: 267998 ms
   Total hot run time: 187873 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3579996519

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3579996631

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532477345

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 188158 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 990f0f07af534d10c25c844c3db0a49149c5aaf4, data reload: false
   
   query1	1042	410	429	410
   query2	6542	1706	1634	1634
   query3	6746	229	229	229
   query4	26532	23501	23478	23478
   query5	4384	611	484	484
   query6	325	235	212	212
   query7	4636	496	293	293
   query8	296	261	246	246
   query9	8651	2598	2603	2598
   query10	501	341	287	287
   query11	15206	15039	15120	15039
   query12	181	128	113	113
   query13	1683	560	436	436
   query14	10294	9169	9258	9169
   query15	221	199	187	187
   query16	7290	704	505	505
   query17	1232	750	605	605
   query18	1983	407	350	350
   query19	207	206	174	174
   query20	137	124	122	122
   query21	214	139	113	113
   query22	3992	4099	3988	3988
   query23	34335	33179	33243	33179
   query24	8441	2421	2436	2421
   query25	582	525	451	451
   query26	1238	277	158	158
   query27	2767	487	350	350
   query28	4382	2231	2200	2200
   query29	833	658	478	478
   query30	307	220	196	196
   query31	900	801	727	727
   query32	86	73	74	73
   query33	584	366	336	336
   query34	791	853	519	519
   query35	814	837	727	727
   query36	949	1018	898	898
   query37	121	109	85	85
   query38	3505	3548	3474	3474
   query39	1476	1425	1402	1402
   query40	218	130	116	116
   query41	63	60	61	60
   query42	133	110	112	110
   query43	502	496	487	487
   query44	1235	777	740	740
   query45	198	183	173	173
   query46	883	985	639	639
   query47	1754	1778	1683	1683
   query48	402	437	330	330
   query49	748	485	427	427
   query50	652	682	400	400
   query51	4072	3975	3919	3919
   query52	110	108	100	100
   query53	236	261	201	201
   query54	340	296	280	280
   query55	90	89	90	89
   query56	336	347	323	323
   query57	1159	1188	1123	1123
   query58	303	293	290	290
   query59	2544	2771	2551	2551
   query60	370	347	349	347
   query61	195	186	188	186
   query62	835	753	664	664
   query63	242	202	201	201
   query64	4676	1281	948	948
   query65	4054	4015	3913	3913
   query66	1179	458	373	373
   query67	15275	15034	14882	14882
   query68	8181	933	603	603
   query69	517	325	300	300
   query70	1334	1342	1293	1293
   query71	434	349	328	328
   query72	6039	4906	4798	4798
   query73	642	574	362	362
   query74	9111	9032	8767	8767
   query75	3256	3328	2810	2810
   query76	3274	1158	753	753
   query77	528	395	330	330
   query78	9546	9712	8875	8875
   query79	2723	830	597	597
   query80	998	567	498	498
   query81	518	270	238	238
   query82	395	159	132	132
   query83	265	258	245	245
   query84	268	116	93	93
   query85	890	481	450	450
   query86	405	335	288	288
   query87	3730	3684	3626	3626
   query88	4050	2220	2217	2217
   query89	406	340	296	296
   query90	1961	221	222	221
   query91	164	162	149	149
   query92	79	70	68	68
   query93	2554	980	640	640
   query94	781	442	337	337
   query95	389	319	300	300
   query96	492	566	276	276
   query97	2895	2978	2846	2846
   query98	249	218	220	218
   query99	1333	1418	1303	1303
   Total cold run time: 275617 ms
   Total hot run time: 188158 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3533089689

   # BE Regression && UT Coverage Report
   Increment line coverage `84.82% (95/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_990f0f07af534d10c25c844c3db0a49149c5aaf4_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_990f0f07af534d10c25c844c3db0a49149c5aaf4_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.51% (24332/34027) |
   | Line Coverage     | 57.98% (252932/436226) |
   | Region Coverage   | 53.47% (211308/395196) |
   | Branch Coverage   | 54.65% (90024/164714) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3540668873

   # BE UT Coverage Report
   Increment line coverage `0.00% (0/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/77ec0e07dffc0efe4c22a9546a7915368a7b4da4_77ec0e07dffc0efe4c22a9546a7915368a7b4da4/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/77ec0e07dffc0efe4c22a9546a7915368a7b4da4_77ec0e07dffc0efe4c22a9546a7915368a7b4da4/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.74% (18274/34649) |
   | Line Coverage     | 38.12% (166120/435835) |
   | Region Coverage   | 33.09% (129198/390470) |
   | Branch Coverage   | 33.83% (55416/163818) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568928680

   # BE UT Coverage Report
   Increment line coverage `0.00% (0/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/abbe9f201e45558f044c8588742f73023282f4f7_abbe9f201e45558f044c8588742f73023282f4f7/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/abbe9f201e45558f044c8588742f73023282f4f7_abbe9f201e45558f044c8588742f73023282f4f7/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.62% (18278/34737) |
   | Line Coverage     | 38.06% (166306/436963) |
   | Region Coverage   | 33.01% (129295/391693) |
   | Branch Coverage   | 33.80% (55489/164152) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3544702607

   > > > I doubt that the compression property on databases does not work, please add a case to check it.
   > > 
   > > 
   > > I've verified that it indeed doesn't work — the table's compression algorithm is only derived from table-level properties or the global default configuration. I'll modify the test cases.
   > 
   > I think we can remove the compression property from database.
   
   It seems like a validation issue — when executing CREATE DATABASE, there is no strict validation for the PROPERTIES parameter in the DDL statement. Most arbitrary parameters entered will still allow the DDL to pass. For example:
   `ALTER DATABASE test_database_properties_db SET PROPERTIES ("test_p1" = "test_p1");
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "Zhou-lemon (via GitHub)" <gi...@apache.org>.
Zhou-lemon commented on code in PR #58034:
URL: https://github.com/apache/doris/pull/58034#discussion_r2553170334


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -1565,6 +1578,81 @@ private static TFetchSchemaTableDataResult tablePropertiesMetadataResult(TSchema
         return result;
     }
 
+    private static TFetchSchemaTableDataResult databasePropertiesMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        if (!params.isSetDbId()) {
+            return errorResult("current db id is not set.");
+        }
+        if (!params.isSetCatalog()) {
+            return errorResult("current catalog is not set.");
+        }
+
+        TUserIdentity tcurrentUserIdentity = params.getCurrentUserIdent();
+        UserIdentity currentUserIdentity = UserIdentity.fromThrift(tcurrentUserIdentity);
+        TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+        Long dbId = params.getDbId();
+        String clg = params.getCatalog();
+        List<TRow> dataBatch = Lists.newArrayList();
+        CatalogIf catalog = Env.getCurrentEnv().getCatalogMgr().getCatalog(clg);
+        if (catalog == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+        DatabaseIf databaseIf = catalog.getDbNullable(dbId);
+        if (databaseIf == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+
+        if (catalog instanceof InternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),
+                    databaseIf.getFullName(), PrivPredicate.SHOW)) {
+                result.setDataBatch(dataBatch);
+                result.setStatus(new TStatus(TStatusCode.OK));
+                return result;
+            }
+            Database db = (Database) databaseIf;
+            Map<String, String> props = db.getDbProperties().getProperties();
+            if (props == null || props.isEmpty()) {
+                TRow trow = new TRow();
+                trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+                trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+                trow.addToColumnValue(new TCell().setStringVal(""));
+                trow.addToColumnValue(new TCell().setStringVal(""));
+                dataBatch.add(trow);
+            } else {
+                props.forEach((key, value) -> {
+                    TRow trow = new TRow();
+                    trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+                    trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+                    trow.addToColumnValue(new TCell().setStringVal(key));
+                    trow.addToColumnValue(new TCell().setStringVal(value));
+                    dataBatch.add(trow);
+                });
+            }
+        } else if (catalog instanceof ExternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),
+                    databaseIf.getFullName(), PrivPredicate.SHOW)) {
+                result.setDataBatch(dataBatch);
+                result.setStatus(new TStatus(TStatusCode.OK));
+                return result;
+            }
+            TRow trow = new TRow();
+            trow.addToColumnValue(new TCell().setStringVal(catalog.getName()));
+            trow.addToColumnValue(new TCell().setStringVal(databaseIf.getFullName()));
+            trow.addToColumnValue(new TCell().setStringVal(""));

Review Comment:
   done



##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -1565,6 +1578,81 @@ private static TFetchSchemaTableDataResult tablePropertiesMetadataResult(TSchema
         return result;
     }
 
+    private static TFetchSchemaTableDataResult databasePropertiesMetadataResult(TSchemaTableRequestParams params) {
+        if (!params.isSetCurrentUserIdent()) {
+            return errorResult("current user ident is not set.");
+        }
+        if (!params.isSetDbId()) {
+            return errorResult("current db id is not set.");
+        }
+        if (!params.isSetCatalog()) {
+            return errorResult("current catalog is not set.");
+        }
+
+        TUserIdentity tcurrentUserIdentity = params.getCurrentUserIdent();
+        UserIdentity currentUserIdentity = UserIdentity.fromThrift(tcurrentUserIdentity);
+        TFetchSchemaTableDataResult result = new TFetchSchemaTableDataResult();
+        Long dbId = params.getDbId();
+        String clg = params.getCatalog();
+        List<TRow> dataBatch = Lists.newArrayList();
+        CatalogIf catalog = Env.getCurrentEnv().getCatalogMgr().getCatalog(clg);
+        if (catalog == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+        DatabaseIf databaseIf = catalog.getDbNullable(dbId);
+        if (databaseIf == null) {
+            result.setDataBatch(dataBatch);
+            result.setStatus(new TStatus(TStatusCode.OK));
+            return result;
+        }
+
+        if (catalog instanceof InternalCatalog) {
+            if (!Env.getCurrentEnv().getAccessManager().checkDbPriv(currentUserIdentity, catalog.getName(),

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568681339

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/abbe9f201e45558f044c8588742f73023282f4f7_abbe9f201e45558f044c8588742f73023282f4f7_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/abbe9f201e45558f044c8588742f73023282f4f7_abbe9f201e45558f044c8588742f73023282f4f7_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 80.86% (1707/2111) |
   | Line Coverage     | 66.88% (29899/44708) |
   | Region Coverage   | 67.41% (14906/22114) |
   | Branch Coverage   | 57.59% (7929/13768) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3568836781

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 34620 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit abbe9f201e45558f044c8588742f73023282f4f7, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17397	5133	4998	4998
   q2	2023	314	205	205
   q3	10169	1291	750	750
   q4	10241	982	386	386
   q5	7515	2367	2401	2367
   q6	188	171	137	137
   q7	924	771	622	622
   q8	9352	1309	1126	1126
   q9	7223	5358	5488	5358
   q10	6920	2253	1835	1835
   q11	520	301	294	294
   q12	362	369	226	226
   q13	17784	3700	3055	3055
   q14	242	232	217	217
   q15	564	508	514	508
   q16	1057	997	932	932
   q17	616	892	374	374
   q18	7646	7213	7157	7157
   q19	1091	981	572	572
   q20	379	341	235	235
   q21	3821	3243	2315	2315
   q22	1017	999	951	951
   Total cold run time: 107051 ms
   Total hot run time: 34620 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	5077	5009	5011	5009
   q2	327	405	312	312
   q3	2168	2737	2287	2287
   q4	1344	1755	1294	1294
   q5	4226	4520	4492	4492
   q6	217	174	126	126
   q7	2059	1968	1839	1839
   q8	2680	2539	2562	2539
   q9	7629	7512	7784	7512
   q10	3063	3306	2815	2815
   q11	617	513	522	513
   q12	692	794	687	687
   q13	3511	4019	3360	3360
   q14	299	318	299	299
   q15	532	484	487	484
   q16	1091	1091	1080	1080
   q17	1203	1569	1388	1388
   q18	8041	7640	7482	7482
   q19	824	815	937	815
   q20	2032	1994	1828	1828
   q21	4682	4419	4228	4228
   q22	1097	1064	995	995
   Total cold run time: 53411 ms
   Total hot run time: 51384 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3569234765

   # FE Regression Coverage Report
   Increment line coverage `  73.44% (47/64)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_abbe9f201e45558f044c8588742f73023282f4f7_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3532851711

   # BE UT Coverage Report
   Increment line coverage `0.00% (0/112)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/990f0f07af534d10c25c844c3db0a49149c5aaf4_990f0f07af534d10c25c844c3db0a49149c5aaf4/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/990f0f07af534d10c25c844c3db0a49149c5aaf4_990f0f07af534d10c25c844c3db0a49149c5aaf4/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.81% (18285/34627) |
   | Line Coverage     | 38.18% (166279/435552) |
   | Region Coverage   | 33.19% (129327/389685) |
   | Branch Coverage   | 33.90% (55476/163639) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feat](metadata) Add system table information.database_properties [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #58034:
URL: https://github.com/apache/doris/pull/58034#issuecomment-3541008428

   # FE Regression Coverage Report
   Increment line coverage `  58.44% (45/77)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/58034_77ec0e07dffc0efe4c22a9546a7915368a7b4da4_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org