[jira] [Commented] (AIRFLOW-4790) dag processing statsd metrics are implemented as gauges but should be timers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863165#comment-16863165 ] 

ASF GitHub Bot commented on AIRFLOW-4790:
-----------------------------------------

andrewhharmon commented on pull request #5414: [AIRFLOW-4790] Change dag processing stats to timers
URL: https://github.com/apache/airflow/pull/5414
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following issues and references them in the PR title. 
     - https://issues.apache.org/jira/browse/AIRFLOW-4790
   
   ### Description
   
   - [x] the stasd metrics for dag processing should be changed from gauges to timers
   
   ### Tests
   
   - [x] scheduler job already has unit test
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - updated metrics docs
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> dag processing statsd metrics are implemented as gauges but should be timers
> ----------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4790
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4790
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 1.10.3
>            Reporter: Andrew Harmon
>            Assignee: Andrew Harmon
>            Priority: Minor
>
> These two metrics were implemented as gauges but should be timers to follow the convention of other metrics that measure how long something takes to run.
> dag_processing.last_runtime.<dag_file>
> dag_processing.last_run.seconds_ago.<dag_file>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)