You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Mousius (via GitHub)" <gi...@apache.org> on 2023/07/18 16:30:32 UTC
[GitHub] [tvm] Mousius opened a new pull request, #15352: [CI] Make Graviton3 default AArch64 job runner node
Mousius opened a new pull request, #15352:
URL: https://github.com/apache/tvm/pull/15352
In order to support SVE testing, migrating the current default AArch64 nodes to Graviton3 based nodes. Using r7g.large instances which have the memory requirements to support the TVM workloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #15352:
URL: https://github.com/apache/tvm/pull/15352#issuecomment-1640671059
Thanks, it would be useful to have a analysis of cost and the way we structure the tests.
As of now running the UTs directly through e2e compilation can take up a lot of CI time. A lot of that comes from tests that are as a matter of fact integration tests that do not have to do with SVE.
Ideally we should isolate out a limited set of integration tests(e.g. via `tests/arm_sve/`) and only run those. There is also a preliminary solution via `require_cuda` tag, that optionally disables the related tests when they are not available. As such majority of tests do not have to go through the specific hw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a diff in pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on code in PR #15352:
URL: https://github.com/apache/tvm/pull/15352#discussion_r1267105149
##########
ci/jenkins/templates/arm_jenkinsfile.groovy.j2:
##########
@@ -19,7 +19,7 @@
{% call m.invoke_build(
name='BUILD: arm',
- node='ARM-SMALL',
+ node='ARM-GRAVITON3',
Review Comment:
Thanks, it would be useful to have a analysis of cost and the way we structure the tests.
As of now running the UTs directly through e2e compilation can take up a lot of CI time. A lot of that comes from tests that are as a matter of fact integration tests
Would be great for us to isolate out a limited set of integration tests (in cases with `tests/arm_sve/`) and only run limited set of testcases over these would be useful. Like our `require_cuda` tag, while majority of tests do not have to go through the specific nodes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #15352:
URL: https://github.com/apache/tvm/pull/15352#issuecomment-1641055621
OK get it, seems to be good on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] ashutosh-arm merged pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "ashutosh-arm (via GitHub)" <gi...@apache.org>.
ashutosh-arm merged PR #15352:
URL: https://github.com/apache/tvm/pull/15352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15352:
URL: https://github.com/apache/tvm/pull/15352#issuecomment-1640555715
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @areusch, @leandron <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Mousius commented on pull request #15352: [CI] Make Graviton3 default AArch64 job runner node
Posted by "Mousius (via GitHub)" <gi...@apache.org>.
Mousius commented on PR #15352:
URL: https://github.com/apache/tvm/pull/15352#issuecomment-1641032501
@tqchen the new instance type is slightly more expensive on paper, as detailed below:
| CI | Instance Type | On-Demand | Reserved | Minimum Spot |
| ---- | ---- | ------------- | ------------- | ------ |
| `ARM-GRAVITON3` | r7g.large | $87.5270 monthly | $57.8890 monthly | $49.1290 monthly |
| `ARM-SMALL` | r6g.large | $82.3440 monthly | $51.9030 monthly | $48.0340 monthly |
However, the new generation of instance has been proven to improve performance (see: [Re:invent presentation](https://d1.awsstatic.com/events/Summits/reinvent2022/CMP327_AWS-Graviton-deep-dive-The-best-price-performance-for-your-AWS-workloads.pdf)). Which indicates this is an improvement for CI costs.
If you look at the diff, this replaces the `r6g.large` instances with `r7g.large` instances and does not add any additional nodes, replacing the existing AArch64 CI with a new instance type that can also run the SVE tests. That means the SVE tests will already be targeted appropriately to AArch64, and this isn't an entirely new set of nodes specifically catering to just SVE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org