You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/27 18:06:49 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
amaliujia opened a new pull request, #38415:
URL: https://github.com/apache/spark/pull/38415
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In the past, Connect server can check `alias` for `Read` and `Project`. However for Spark DataFrame, every DataFrame can be chained with `as(alias: String)` thus every Relation/LogicalPlan can have an `alias`. This PR refactors to make this work.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Improve API coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1010018988
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -213,3 +213,13 @@ message Sample {
int64 seed = 1;
}
}
+
+// Relation alias.
+message SubqueryAlias {
+ // Required. The input relation.
+ Relation input = 1;
+ // Required. The alias.
Review Comment:
Given our discussion on the protocol, this is a required field so we ask clients to always set it. Server side only fetch the value in this field not matter what it is (either `""`, or not)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #38415:
URL: https://github.com/apache/spark/pull/38415#issuecomment-1298019712
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38415:
URL: https://github.com/apache/spark/pull/38415#issuecomment-1293887655
R: @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007552036
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
why can't we use string directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007555285
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
oh, I thought the default value of string is null...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38415:
URL: https://github.com/apache/spark/pull/38415#issuecomment-1295679630
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007556667
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
default is empty string...
I really don't like the way of proto for this..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007553459
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
do you think if we need to care client call `xx.as("")`? Does client side should reject this? If so we can just use a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1009076916
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -213,3 +213,13 @@ message Sample {
int64 seed = 1;
}
}
+
+// Relation alias.
+message SubqueryAlias {
+ // Required. The input relation.
+ Relation input = 1;
+ // Required. The alias.
Review Comment:
how can we check if it's present or not, given the default value is empty string?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007551962
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
Review Comment:
I don't have a strong opinion, but not sure which one is better. We can also follow catalyst, and add a new plan `SubqueryAlias(child, alias)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1007553459
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
+ Alias alias = 200;
+
+ // Relation alias.
+ message Alias {
Review Comment:
do you think if we need to care client call `xx.as("")`? Does client side should reject this? If so we can just use a string.
It's always a matter of if we need to know a field set or not set or default value, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38415:
URL: https://github.com/apache/spark/pull/38415#discussion_r1008797052
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -47,6 +47,13 @@ message Relation {
Unknown unknown = 999;
}
+ // Optional. Every relation might have an alias.
Review Comment:
Given that this is already a message, also if we want to match DataFrame API, I think it makes more sense to have a `SubqueryAlias` in proto, and the call for `as(alias)` in the client will just create this `SubqueryAlias`, which is the same as existing DF implementation.
I have updated this PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #38415: [SPARK-40938][CONNECT] Support Alias for every type of Relation
URL: https://github.com/apache/spark/pull/38415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org