You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/10 15:15:52 UTC

[GitHub] [incubator-nuttx] hartmannathan commented on a change in pull request #2273: stm32/stm32_spi: Add SPI register definitions for STM32G47xxx

hartmannathan commented on a change in pull request #2273:
URL: https://github.com/apache/incubator-nuttx/pull/2273#discussion_r520641075



##########
File path: arch/arm/src/stm32/hardware/stm32_spi.h
##########
@@ -135,7 +150,8 @@
 #define SPI_CR1_SSI               (1 << 8)  /* Bit 8: Internal slave select */
 #define SPI_CR1_SSM               (1 << 9)  /* Bit 9: Software slave management */
 #define SPI_CR1_RXONLY            (1 << 10) /* Bit 10: Receive only */
-#if defined(CONFIG_STM32_STM32F30XX) || defined(CONFIG_STM32_STM32F37XX)
+#if defined(CONFIG_STM32_STM32F30XX) || defined(CONFIG_STM32_STM32F37XX) \

Review comment:
       Yes. I am trying to reduce the ifdef rash in this file. Already added HAVE_SPI_I2S and HAVE_SPI_TI_MODE. I'll add a STM32_HAS_SPI_CRC as well. Makes sense to put it in chip.h file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org