You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/30 09:05:44 UTC
[GitHub] [kafka] dajac opened a new pull request #8954: MINOR; Move quota integration tests to using the new quota API.
dajac opened a new pull request #8954:
URL: https://github.com/apache/kafka/pull/8954
This PR refactors the various quota integration tests in the `kafka.api` package and migrates them to using the new quota API instead of writing the quota to ZK directly.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram merged pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
rajinisivaram merged pull request #8954:
URL: https://github.com/apache/kafka/pull/8954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661906846
Connect test failure unrelated, merging to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-651742771
@ijuma @rajinisivaram Could you review this one when you have time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on a change in pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on a change in pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#discussion_r457270288
##########
File path: core/src/test/scala/integration/kafka/api/BaseQuotaTest.scala
##########
@@ -335,12 +339,31 @@ abstract class QuotaTestClients(topic: String,
assertEquals("Should not have been throttled", 0.0, metricValue(maxMetric), 0.0)
}
- def quotaProperties(producerQuota: Long, consumerQuota: Long, requestQuota: Double): Properties = {
- val props = new Properties()
- props.put(DynamicConfig.Client.ProducerByteRateOverrideProp, producerQuota.toString)
- props.put(DynamicConfig.Client.ConsumerByteRateOverrideProp, consumerQuota.toString)
- props.put(DynamicConfig.Client.RequestPercentageOverrideProp, requestQuota.toString)
- props
+ // Default is set by using Some(null) for either or both user and clientId
Review comment:
Maybe add a constant for the default entity and use `Some(DefaultEntity)` which would avoid the need for the comment that sounds like we are doing something we shouldn't be.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rajinisivaram commented on pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
rajinisivaram commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661074391
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #8954: MINOR; Move quota integration tests to using the new quota API.
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #8954:
URL: https://github.com/apache/kafka/pull/8954#issuecomment-661056556
@rajinisivaram Thanks for the review. I just pushed an updated that addressed your comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org