You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/08/29 20:25:04 UTC

[GitHub] activemq-artemis pull request #2281: ARTEMIS-2023 Avoiding boolean on every ...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2281

    ARTEMIS-2023 Avoiding boolean on every message for 1x and tests

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis compatible-changes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2281
    
----
commit 2898a80834c345c2add71bcb849e5d7cbe575a2c
Author: Clebert Suconic <cl...@...>
Date:   2018-08-28T21:35:57Z

    ARTEMIS-2023 Avoiding boolean on every message for 1x and tests

----


---

[GitHub] activemq-artemis issue #2281: ARTEMIS-2023 Avoiding boolean on every message...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2281
  
    @michaelandrepearce it's not there any longer. it's just Session. Just using extension instead of boolean. that's all.


---

[GitHub] activemq-artemis pull request #2281: ARTEMIS-2023 Avoiding boolean on every ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2281


---

[GitHub] activemq-artemis issue #2281: ARTEMIS-2023 Avoiding boolean on every message...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2281
  
    Can we remove the need for core session to know about a jms 1x fix with this?


---

[GitHub] activemq-artemis issue #2281: ARTEMIS-2023 Avoiding boolean on every message...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2281
  
    For some reason compatibility-tests are broken. I didn't break compatibility tests.. but there's something I need to fix.
    
    
    I planning this to be the last PR before releasing. (and cherry-pick)


---