You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Na Li <li...@cloudera.com> on 2017/04/28 20:22:30 UTC
Review Request 58854: Add log message for key store path in test file
SentryServiceIntegrationBase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/
-----------------------------------------------------------
Review request for sentry and Alexander Kolbasov.
Repository: sentry
Description
-------
add debug log message to help find root cause of SENTRY-1400
Diffs
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
Diff: https://reviews.apache.org/r/58854/diff/1/
Testing
-------
Thanks,
Na Li
Re: Review Request 58854: Add log message for key store path in test
file SentryServiceIntegrationBase
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/#review173397
-----------------------------------------------------------
What JIRA is this?
- Alexander Kolbasov
On April 28, 2017, 8:22 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58854/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 8:22 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add debug log message to help find root cause of SENTRY-1400
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
>
>
> Diff: https://reviews.apache.org/r/58854/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 58854: SENTRY-1733 Add log message for key store
path in test file SentryServiceIntegrationBase
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/#review173521
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On May 1, 2017, 3:02 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58854/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 3:02 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add debug log message to help find root cause of SENTRY-1400
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
>
>
> Diff: https://reviews.apache.org/r/58854/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 58854: SENTRY-1733 Add log message for key store
path in test file SentryServiceIntegrationBase
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/
-----------------------------------------------------------
(Updated May 10, 2017, 8:29 p.m.)
Review request for sentry and Alexander Kolbasov.
Repository: sentry
Description
-------
add debug log message to help find root cause of SENTRY-1400
Diffs
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
Diff: https://reviews.apache.org/r/58854/diff/2/
Testing (updated)
-------
test that
LOGGER.debug("{} is at {}", ServerConfig.SENTRY_WEB_SSL_KEYSTORE_PATH, keystorePath);
output the expected log message
Thanks,
Na Li
Re: Review Request 58854: SENTRY-1733 Add log message for key store
path in test file SentryServiceIntegrationBase
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/
-----------------------------------------------------------
(Updated May 1, 2017, 3:02 p.m.)
Review request for sentry and Alexander Kolbasov.
Repository: sentry
Description
-------
add debug log message to help find root cause of SENTRY-1400
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
Diff: https://reviews.apache.org/r/58854/diff/2/
Changes: https://reviews.apache.org/r/58854/diff/1-2/
Testing
-------
Thanks,
Na Li
Re: Review Request 58854: SENTRY-1733 Add log message for key store
path in test file SentryServiceIntegrationBase
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/
-----------------------------------------------------------
(Updated May 1, 2017, 2:42 p.m.)
Review request for sentry and Alexander Kolbasov.
Summary (updated)
-----------------
SENTRY-1733 Add log message for key store path in test file SentryServiceIntegrationBase
Repository: sentry
Description
-------
add debug log message to help find root cause of SENTRY-1400
Diffs
-----
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
Diff: https://reviews.apache.org/r/58854/diff/1/
Testing
-------
Thanks,
Na Li
Re: Review Request 58854: SENTRY-1733 Add log message for key store
path in test file SentryServiceIntegrationBase
Posted by Na Li <li...@cloudera.com>.
> On April 28, 2017, 11:21 p.m., Alexander Kolbasov wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
> > Lines 189 (patched)
> > <https://reviews.apache.org/r/58854/diff/1/?file=1703532#file1703532line190>
> >
> > Do we support this style of format string? In other places we use {}-style formatting.
I have changed it to use {}-style
- Na
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/#review173398
-----------------------------------------------------------
On May 1, 2017, 3:02 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58854/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 3:02 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add debug log message to help find root cause of SENTRY-1400
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
>
>
> Diff: https://reviews.apache.org/r/58854/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Na Li
>
>
Re: Review Request 58854: Add log message for key store path in test
file SentryServiceIntegrationBase
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58854/#review173398
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
Lines 189 (patched)
<https://reviews.apache.org/r/58854/#comment246396>
Do we support this style of format string? In other places we use {}-style formatting.
- Alexander Kolbasov
On April 28, 2017, 8:22 p.m., Na Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58854/
> -----------------------------------------------------------
>
> (Updated April 28, 2017, 8:22 p.m.)
>
>
> Review request for sentry and Alexander Kolbasov.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> add debug log message to help find root cause of SENTRY-1400
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java dfd79ae
>
>
> Diff: https://reviews.apache.org/r/58854/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Na Li
>
>