[GitHub] [doris] dataroaring commented on a diff in pull request #13495: [enhancement](compaction) opt compaction task producer and quick compaction

[GitBox <gi...@apache.org>]

dataroaring commented on code in PR #13495:
URL: https://github.com/apache/doris/pull/13495#discussion_r1000184979


##########
be/src/olap/delta_writer.cpp:
##########
@@ -114,9 +114,8 @@ Status DeltaWriter::init() {
     // check tablet version number
     if (_tablet->version_count() > config::max_tablet_version_num) {

Review Comment:
   Should we trigger a compaction before encountering an error. e.g.
   if (_tablet->version_count() > config::max_tablet_version_num - 10) {
        // submit a compaction task?
   }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org