You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "cshannon (via GitHub)" <gi...@apache.org> on 2024/08/25 17:05:30 UTC
[PR] Updates 2.1 to mark member variables that can be final [accumulo]
cshannon opened a new pull request, #4836:
URL: https://github.com/apache/accumulo/pull/4836
This applies the same updates from #4835 to 2.1
Updates to mark member variables that can be final in the following modules:
core, server-base hadoop-mapreduce, gc, manager, tserver
Issue #4830
**Note:** This should be merged forward into /3.1 by itself as an empty commit using `git merge -s ours` because 3.1 and elasticity already had these changes applied in other PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark member variables that can be final in 2.1 [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #4836:
URL: https://github.com/apache/accumulo/pull/4836#issuecomment-2310544641
I inadvertently marked a jcommander parameter final (which you can't do) and that was changed in 3.1 and main (now elasticity). I fixed it and re-kicked the full build. The issue was preventing a ScanServer from starting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark member variables that can be final in 2.1 [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #4836:
URL: https://github.com/apache/accumulo/pull/4836#issuecomment-2311100187
full IT build passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark member variables that can be final in 2.1 [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #4836:
URL: https://github.com/apache/accumulo/pull/4836#issuecomment-2310104932
The full IT build for this PR hung up on Jenkins and never finished, I'm re-running the build to see if it was a weird Jenkins issue and I will also try the ITs locally to see if they are real failures when I get a chance today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark member variables that can be final in 2.1 [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon merged PR #4836:
URL: https://github.com/apache/accumulo/pull/4836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mark member variables that can be final in 2.1 [accumulo]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #4836:
URL: https://github.com/apache/accumulo/pull/4836#issuecomment-2308930501
I kicked off a full IT build to make sure it passes before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org