You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/27 13:12:19 UTC
[GitHub] [superset] villebro commented on a diff in pull request #19866: chore: fix explore pills
villebro commented on code in PR #19866:
URL: https://github.com/apache/superset/pull/19866#discussion_r859780407
##########
superset-frontend/src/components/AlteredSliceTag/index.jsx:
##########
@@ -183,9 +193,7 @@ export default class AlteredSliceTag extends React.Component {
renderTriggerNode() {
return (
<Tooltip id="difference-tooltip" title={t('Click to see difference')}>
- <span className="label label-warning" style={{ fontSize: '12px' }}>
- {t('Altered')}
- </span>
+ <StyledLabel className="label">{t('Altered')}</StyledLabel>
Review Comment:
Unfortunately it's still needed as I wasn't able to migrate to the `Label` component yet due to the inconsistent colors (the outline that is rendered if the Label has a click handler is way too dark right now; we chatted about it earlier today with Kasia):
But once that gets sorted This will be completely refactored to use the `Label` component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org