[GitHub] [doris] morningman commented on a diff in pull request #19110: [fix](Metadata tvf) Metadata TVF supports read the specified columns from Fe

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #19110:
URL: https://github.com/apache/doris/pull/19110#discussion_r1178551250


##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -257,14 +262,37 @@ private static TFetchSchemaTableDataResult resourceGroupsMetadataResult(TMetadat
             trow.addToColumnValue(new TCell().setStringVal(rGroupsInfo.get(1)));
             trow.addToColumnValue(new TCell().setStringVal(rGroupsInfo.get(2)));
             trow.addToColumnValue(new TCell().setIntVal(value));
-            dataBatch.add(trow);
+            TRow filterRow = filterColumns(trow, params.getColumnsName(), TMetadataType.RESOURCE_GROUPS);

Review Comment:
   I think we can use a more easy way to implement this. To avoid copy duplicate code for each TVF.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org