You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2015/07/29 15:16:50 UTC
[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-js/pull/123
CB-9429 Enables jsdom/browser tests for browserify
This PR implements [CB-9429](https://issues.apache.org/jira/browse/CB-9429). It also:
- Fixes browser-based tests problems (browser not launched, tests files served improperly), so `grunt btest` command now works.
- Adds `test` platform to `compile-browserify` target
- Add `test-browserify` and `btest-browserify` Grunt targets to run cordova-js tests against browserified bundle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-js CB-9429
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-js/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit ba4dcd8e0a0458c1969d4ec7e3965d37d74f1958
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-29T07:49:56Z
Enables/fixes browser-based tests
Also enables both browser and JSDom tests for browserify flow.
commit adbe1885b118161f0bd19d82a748653ae0f8ba25
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-29T10:42:11Z
CB-9429 Enables jsdom/browser tests for browserify
commit 42e6a6d26f7eb224e7317d6831f4028f9f7abc69
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-29T10:42:11Z
Moves test platform sources to platforms directory
Updates tests with new test platform paths
Updates bundlers to use new test platform path
commit 4107d66a0f59000096f868a46aebb40d8f6688f2
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-07-29T10:42:11Z
Fixes malformed bundle by adding symbol list
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/123
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-js/pull/123#issuecomment-126489678
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org