[GitHub] [airflow] syun64 commented on pull request #29038: Add HttpHookAsync for deferrable implementation

["syun64 (via GitHub)" <gi...@apache.org>]

syun64 commented on PR #29038:
URL: https://github.com/apache/airflow/pull/29038#issuecomment-1429965398

   @kaxil @sunank200 I'm not an expert on this provider, but it looks like test_do_api_call_async_retryable_error at tests/providers/http/hooks/test_http.py:436 was committed with a failing test. It seems to me that the underlying aioreponses request_mock call is raising a ClientConnectionError, which isn't caught in [HttpAsyncHook](https://github.com/apache/airflow/blob/28126c12fbdd2cac84e0fbcf2212154085aa5ed9/airflow/providers/http/hooks/http.py#L374) did you have a specific way you wanted to handle the ClientConnectionError? If not, I could try to treat it similarly to how you are handling [ClientResponseError](https://github.com/apache/airflow/blob/28126c12fbdd2cac84e0fbcf2212154085aa5ed9/airflow/providers/http/hooks/http.py#L374) and patch it up on my open PR: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org