You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "SolidWallOfCode (via GitHub)" <gi...@apache.org> on 2023/04/03 22:00:03 UTC
[GitHub] [trafficserver] SolidWallOfCode opened a new pull request, #9581: libswoc: Replace ts::file with swoc::file
SolidWallOfCode opened a new pull request, #9581:
URL: https://github.com/apache/trafficserver/pull/9581
This is a draft because it requires an update to libswoc.
Gancho added quite a bit of functionality I was unaware of that had to be ported to libswoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1502427735
[approve ci autest 1of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1502468637
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1502427024
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1500766611
The biggest pain not related to OSX was Gancho implemented `remove_all` but named it `remove`, which is also in `std::filesystem` but does something different (i.e. recursive vs. regular file only). There were many places where `remove` was used to clean a directory, which no longer works. I changed the names for `std::filesystem` compliance. I'm not sure why Gancho used slightly different names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode merged pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode merged PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #9581: libswoc: Replace ts::file with swoc::file
Posted by "SolidWallOfCode (via GitHub)" <gi...@apache.org>.
SolidWallOfCode commented on PR #9581:
URL: https://github.com/apache/trafficserver/pull/9581#issuecomment-1502426391
[ci approve autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org