[GitHub] [airflow] nuclear0wl commented on a diff in pull request #29752: Make Liveness/Readiness Probe timeouts configurable for PgBouncer Exporter

["nuclear0wl (via GitHub)" <gi...@apache.org>]

nuclear0wl commented on code in PR #29752:
URL: https://github.com/apache/airflow/pull/29752#discussion_r1117838465


##########
chart/values.schema.json:
##########
@@ -4588,6 +4588,56 @@
                                 "verify-full"
                             ],
                             "default": "disable"
+                        },
+                        "livenessProbe": {
+                            "description": "LivenessProbe configurations for ``metricsExporterSidecar``",
+                            "type": "object",
+                            "additionalProperties": false,
+                            "properties": {
+                                "initialDelaySeconds": {
+                                    "description": "Metrics Exporter liveness probe initial delay",
+                                    "format": "int32",
+                                    "type": "integer",
+                                    "default": 10
+                                },
+                                "periodSeconds": {
+                                    "description": "Metrics Exporter liveness probe frequency",
+                                    "format": "int32",

Review Comment:
   I reviewed it again and pretty agree that it's quite extra to be here. Removed format fields, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org