[GitHub] jerrypeng commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #2549: [Function] avoid creating assignment snapshot and publish individual assignment msg
URL: https://github.com/apache/incubator-pulsar/pull/2549#discussion_r217500097
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/Function.proto
 ##########
 @@ -133,4 +133,5 @@ message Instance {
 message Assignment {
     Instance instance = 1;
     string workerId = 2;
+    bool removed = 3;
 
 Review comment:
   Ya we should set the key of the assignment to be null so that during compaction the assignment will be removed.  If we don't do that, the assignment topic will still be littered with potentially many defunct assignments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services