You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/08/08 08:39:56 UTC
[GitHub] zeppelin pull request #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1302
[ZEPPELIN-1306] Interpreter restarts on a note.
### What is this PR for?
This PR is for usability of restarting interpreter.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1306
### How should this be tested?
You can restart interpreter on the interpreter binding page on a note.
and can only restart ```scoped``` and ```isolated``` interpreter.
Please refer to screen shot.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1302
----
commit 5ad4503951e4444252b5a8be52f66a271e1ac913
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-08T07:26:32Z
Interpreter restarts on a note.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Thanks for the contribution.
How about make UI little bit more consistent?
On interpreter setting page, we have interpreter restart button look like
And interpreter binding page now have different style of restart button
How about use the similar style and similar icon for interpreter restart button? so user can easily guess what this button is for. For example,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Can you rebase so that we can check the CI?
I will merge after it's green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by kjmrknsn <gi...@git.apache.org>.
Github user kjmrknsn commented on the issue:
https://github.com/apache/zeppelin/pull/1302
The bug that "auto-restart interpreter on cron execution" restarts all interpreters will be fixed by https://github.com/apache/zeppelin/pull/2681.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Definitely looks better! I like @Leemoonsoo 's idea \U0001f44d
It's just my personal opinion, how about putting `refresh` icon to the left side of the interpreter name? I mean
- Before
<img width="715" alt="screen shot 2016-08-28 at 12 30 26 pm" src="https://cloud.githubusercontent.com/assets/10060731/18031438/96ca6208-6d1b-11e6-9022-109d7e6fe85c.png">
- After
<img width="782" alt="screen shot 2016-08-28 at 12 29 11 pm" src="https://cloud.githubusercontent.com/assets/10060731/18031439/9d8905cc-6d1b-11e6-987a-ec9dd1f8a4e9.png">
And while we are familiar with the feature; "Restart Interpreter", some ppl may not. So what about showing some message with tooltip like this?
<img width="64" alt="screen shot 2016-08-28 at 12 37 23 pm" src="https://cloud.githubusercontent.com/assets/10060731/18031452/6acf5a40-6d1c-11e6-912e-4c5af35e68ed.png">
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim @corneadoug, Shell we have some unittests for `public void restart(String settingId, String noteId)` before we merge? Restarting only a interpreter instance/process for a note is new ability. So i think it make sense to have a unittest.
Also, shell we have https://github.com/apache/zeppelin/blob/master/docs/rest-api/rest-interpreter.md#restart-an-interpreter updated, too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Maybe a spinner just like the save button after editing an interpreter would be enough then.
Its just a matter of having a small feedback.
<img width="144" alt="screen shot 2016-09-05 at 3 21 01 pm" src="https://cloud.githubusercontent.com/assets/710411/18238936/7f06a16a-737c-11e6-88f4-4b65434488f0.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Tested again and it works well. I like it :)
Here is the new UI (for the other reviewers)
@Leemoonsoo If you have some time, could you please check this PR again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Can you add consideration for the multi-tenancy? If Shiro is enabled, current implementation will disable all of users' interpreters
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Ah i see. That definitely looks like a problem. I filed an issue https://issues.apache.org/jira/browse/ZEPPELIN-2995.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by toughrogrammer <gi...@git.apache.org>.
Github user toughrogrammer commented on the issue:
https://github.com/apache/zeppelin/pull/1302
But isn't this original issue also important? I usually want to restart specific notebook. Because spark executors aren't returned automatically, I must kill zeppelin application from YARN web UI. And then, zeppelin notebook lost spark context and I need to restart spark interpreter.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
\cc @Leemoonsoo I fixed UI like following screenshot and process. please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@AhyoungRyu I agree with you!
I changed position and restart icon to button type, is it okay with button or just icon is better?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim I've also thought the interpreter `restart` button in separated page quite uncomfortable. This PR can be a good start for the better UX i think :)
I tested your patch and it almost works well except one thing.
>can only restart `scoped` and `isolated` interpreter.
Since you said like above in the description, I edited `Spark` interpreter as `shared` mode in the interpreter menu and restarted with your new interpreter binding UI. I expected it failed with some error messages, but it restarted. Did I miss sth?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Looks good!
I think it would be better the activated and deactivated interpreter buttons can be in line like below images.
- Before (with this patch)
<img width="395" alt="screen shot 2016-08-31 at 2 15 43 pm" src="https://cloud.githubusercontent.com/assets/10060731/18116842/d2a64028-6f85-11e6-93d0-ea613abf12ad.png">
- After
<img width="380" alt="screen shot 2016-08-31 at 2 15 43 pm" src="https://cloud.githubusercontent.com/assets/10060731/18117512/3cba0ec8-6f8a-11e6-84f5-c6f1bf5ef089.png">
Or I'd like to suggest another option. How about simply changing `Restart` button color to grey for the deactivated interpreter button?(usually the grey color stands for `deactivated` I guess)
<img width="366" alt="screen shot 2016-08-31 at 2 29 40 pm" src="https://cloud.githubusercontent.com/assets/10060731/18117095/6bd23a4e-6f87-11e6-94d5-d08abffb6561.png">
What do you think? :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by toughrogrammer <gi...@git.apache.org>.
Github user toughrogrammer commented on the issue:
https://github.com/apache/zeppelin/pull/1302
How it's going on? I want to restart *note specific interpreter* when cron is executed or refreshing spark context, but current version(0.7.2), it's impossible. It's really unproductive experience.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Looks great to me, thank you @astroshim !
On @corneadoug point - it should be possible to animate the icon button \w arrows to be i.e rotating while "restart is in progress" so it stops spinning, as soon as restart is done. This might give user a nice visual feedback.
But @astroshim is righ, restart is pretty fast due to the nature of implementation - interpreter process just gets killed and then it's is lazy-started only on next time user runs the paragraph where it is binded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@jongyoul I totally agree with you adding multi-tenancy but how about separating that to another PR because we also already have restarting interpreter function in the `Interpreter Setting page` .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
And i think it's more make sense and useful if we can make restart button like,
restart button on interpreter setting page : restart all interpreter instances/processes related to the setting.
restart button on interpreter binding page : restart a interpreter instance/process for the note when "per Note" is enabled. Otherwise restart all interpreter instances/processes.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Oh that was my bad. Please ignore my above comment. I only build `zeppelin-web` not backend side.
Tested again and it works well as expected. Let's wait the other reviewers :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
I just changed to 'icon'.
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@corneadoug I just re-based thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@corneadoug I'm going to add test case soon. :laughing:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@corneadoug Actually it's very short time to restart interpreter job because it's just kill interpreter process or thread.
How about alerting message when request is success?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@Leemoonsoo I agree with your opinion. Let me fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Tested LGTM
@astroshim can you rebase? It should make the CI green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by toughrogrammer <gi...@git.apache.org>.
Github user toughrogrammer commented on the issue:
https://github.com/apache/zeppelin/pull/1302
<img width="310" alt="screen shot 2017-10-14 at 2 39 53 am" src="https://user-images.githubusercontent.com/1473538/31558707-001fa9e6-b089-11e7-9ca6-48aabcc60839.png">
I'm using spark interpreter per note isolated mode and I wrote a notebook for batch job with cron execution. (Please refer to the attached image.)
When this notebook is executed by cron, interpreter is restarted. But problem is other notebook's spark context also to be expired. Every hour I need to re-run all paragraph and read large data set from storage.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Great! Personally I would prefer "just icon" like the reload notes icon in Zeppelin home.
But it's just my personal opinion. Final decision is up to you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
My only feedback is that right now, it's hard to know if the interpreter has finished restarting or not.
My guess is that it takes some time, so you shouldn't be able to restart it again and you should be warned somehow when it's done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Thank you very much about reviewing this PR. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@corneadoug I fixed it. please review. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@Leemoonsoo Your suggestion about UI is definitely better!
and also makes sense about restarting action on interpreter binding page.
I will fix them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
Yeah, i think we can make "auto-restart interpreter on cron execution" checkbox restart specific interpreter instance to the notebook.
---
[GitHub] zeppelin pull request #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
GitHub user astroshim reopened a pull request:
https://github.com/apache/zeppelin/pull/1302
[ZEPPELIN-1306] Interpreter restarts on a note.
### What is this PR for?
This PR is for usability of restarting interpreter.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1306
### How should this be tested?
You can restart interpreter on the interpreter binding page on a note.
and can only restart ```scoped``` and ```isolated``` interpreter.
Please refer to screen shot.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1302
----
commit 5ad4503951e4444252b5a8be52f66a271e1ac913
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-08T07:26:32Z
Interpreter restarts on a note.
commit 439b3613d9ee6bcbf2b60499c6c1d72bb6a9b9d1
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-08T08:50:38Z
fix js code style.
commit 4dbe05ae1c811fed5db0b7bb1575bcdb4c08e8b4
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-14T16:01:36Z
change argument string to boolean
commit 03bdd05cb4d8cec5057c29a1dbe7f14dbf2d3c09
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-17T02:16:21Z
Merge branch 'master' into ZEPPELIN-1306
commit e698e6f91c6acf16605cdc5239096df0e9bfa98e
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-22T02:13:26Z
change method name
commit 322d427f26cf0cbe0108e363126e4ecef14c15d4
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-26T01:22:07Z
Merge branch 'master' into ZEPPELIN-1306
commit 29966a0194df23f67e95450f7fd1b05cd66bb0cb
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-26T16:38:28Z
change UI and restart interpreter process
commit 50c6acf9c796f2908f70845dd4d1c447a0d68863
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-26T16:41:11Z
delete unnecessary code
commit 2cea65bff322f0372d2c1df48ffe1b17823b7aba
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-26T16:56:34Z
change method name
commit f9ea386453e1db6ff8b910bcccdb0bb246445a6e
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-27T15:17:24Z
fix code style
commit a980500f68e6b49c34d7c44342b81bc8a3ff6e22
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-28T11:39:48Z
update html
commit 123882df7dc546539bc4e430ab596ad665d064b6
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-28T13:50:39Z
change button to icon
commit aa30b3966e16fb0da61a963a6ac382190413f720
Author: astroshim <hs...@nflabs.com>
Date: 2016-08-31T15:59:08Z
inactive link when interpreter is not selected.
commit 78fdd74ba8124493086332f5905695db6244004a
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-06T05:05:42Z
update alert message.
commit ecfa7fbccb56bec87b2f2cb6e8fbe6d8736f35f6
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-07T07:47:53Z
remove dud code.
commit 0453402769ab34bc744610f8f9404ff11033ed42
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-09T06:23:56Z
Merge branch 'master' into ZEPPELIN-1306
commit 3127154ef5560bd86f3407d32edc9dd53fa15f71
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-16T13:18:35Z
Merge branch 'master' into ZEPPELIN-1306
commit 72a2259522b6975df069b507d7c8b58ca007d0af
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-16T14:55:42Z
add testcase and fix the doc.
commit 4c4339f513f365aecf55bce466b20a92e4166678
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-21T12:52:34Z
Merge branch 'master' into ZEPPELIN-1306
commit 5c4b32a4646da0e14123e14685e0d58b2b087d02
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-27T02:51:05Z
Merge branch 'master' into ZEPPELIN-1306
commit fa45bb55b2f8311e30cd8ceb7e24c73cb14505a8
Author: astroshim <hs...@nflabs.com>
Date: 2016-09-27T13:05:51Z
remove debug log
commit 36f564273e2eaeeec97453151e315469d8026c90
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-04T14:53:09Z
add InterpreterForNote testcase
commit e8e0c179b11efb9f16deb9a657ea81455e3093eb
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-11T00:05:39Z
rebase
commit 499aa6bf3439b9e2524de59067f6d88eb6aec9bf
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-19T23:31:04Z
add PySparkInterpreter testcase
commit fc1c819fd76b303690fa3fe1250775051e90a313
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-20T13:53:53Z
Merge branch 'ZEPPELIN-1306' of https://github.com/astroshim/zeppelin into ZEPPELIN-1306
commit a6261884906a5f74fbf817a26959d641f930d300
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-21T07:55:06Z
rebase and fixing testcase
commit 4dda64b79df9d18b9b3822015b722bbd0df7e550
Author: astroshim <hs...@nflabs.com>
Date: 2016-10-21T10:51:24Z
rebase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@astroshim Do you some time to rebase, and add more tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@AhyoungRyu I think `deactivated` button is better so I updated it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@corneadoug, @Leemoonsoo I re-based and added testcase. please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1302
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim closed the pull request at:
https://github.com/apache/zeppelin/pull/1302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1302: [ZEPPELIN-1306] Interpreter restarts on a note.
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1302
@toughrogrammer Could you explain little more about the problem? How cron execution is related with restart interpreter?
---