You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/11/05 03:44:02 UTC
[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8473
Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X
......................................................................
[stopwatch] update Stopwatch::GetTimes() on OS X
Updated implementation of Stopwatch::GetTimes() for OS X to output
relevant numbers corresponding to getrusage(..., RUSAGE_THREAD).
The new implementation is modeled after OS X-specific code from
https://codereview.chromium.org/16818003
Example of output prior to the fix:
Time spent creating directory manager: \
real 0.009s user 18446744046.974s sys 0.005s
Example of output after the fix:
Time spent creating directory manager: \
real 0.008s user 0.002s sys 0.006s
Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
---
M src/kudu/gutil/walltime.h
M src/kudu/util/stopwatch.h
2 files changed, 12 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/8473/1
--
To view, visit http://gerrit.cloudera.org:8080/8473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8473 )
Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X
......................................................................
Patch Set 1: Verified+1
Known flake in ClientStressTest.TestUniqueClientIds (the fix is in review: https://gerrit.cloudera.org/#/c/8462/
--
To view, visit http://gerrit.cloudera.org:8080/8473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sun, 05 Nov 2017 05:48:26 +0000
Gerrit-HasComments: No
[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8473 )
Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Nov 2017 17:15:18 +0000
Gerrit-HasComments: No
[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8473 )
Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [stopwatch] update Stopwatch::GetTimes() on OS X
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8473 )
Change subject: [stopwatch] update Stopwatch::GetTimes() on OS X
......................................................................
[stopwatch] update Stopwatch::GetTimes() on OS X
Updated implementation of Stopwatch::GetTimes() for OS X to output
relevant numbers corresponding to getrusage(..., RUSAGE_THREAD).
The new implementation is modeled after OS X-specific code from
https://codereview.chromium.org/16818003
Example of output prior to the fix:
Time spent creating directory manager: \
real 0.009s user 18446744046.974s sys 0.005s
Example of output after the fix:
Time spent creating directory manager: \
real 0.008s user 0.002s sys 0.006s
Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Reviewed-on: http://gerrit.cloudera.org:8080/8473
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/gutil/walltime.h
M src/kudu/util/stopwatch.h
2 files changed, 12 insertions(+), 10 deletions(-)
Approvals:
Alexey Serbin: Verified
Dan Burkert: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I13584e12342e3548c50a38c890b3f2cb18fd3f07
Gerrit-Change-Number: 8473
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>