[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2317: Support Dynamic Partition

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2317: Support Dynamic Partition
URL: https://github.com/apache/incubator-doris/pull/2317#discussion_r351972181
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -1153,6 +1158,10 @@ private void startMasterOnlyDaemonThreads() {
         // start routine load scheduler
         routineLoadScheduler.start();
         routineLoadTaskScheduler.start();
+        // start dynamic partition task
+        dynamicPartitionScheduler.setName("DynamicPartitionScheduler");
+        dynamicPartitionScheduler.setInterval(Config.dynamic_partition_check_interval_seconds * 1000L);
+        dynamicPartitionScheduler.start();
 
 Review comment:
   Would better add a config to disable or enable this feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org