You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/08 08:54:43 UTC
[GitHub] [cloudstack] weizhouapache commented on a change in pull request
#3587: vrouter in redundant mode acquire guest ips from first ip of the tier
weizhouapache commented on a change in pull request #3587: vrouter in redundant mode acquire guest ips from first ip of the tier
URL: https://github.com/apache/cloudstack/pull/3587#discussion_r389349148
##########
File path: server/src/main/java/com/cloud/network/router/NicProfileHelperImpl.java
##########
@@ -118,7 +118,7 @@ public NicProfile createGuestNicProfileForVpcRouter(final RouterDeploymentDefini
final NicProfile guestNic = new NicProfile();
if (vpcRouterDeploymentDefinition.isRedundant()) {
- guestNic.setIPv4Address(_ipAddrMgr.acquireGuestIpAddress(guestNetwork, null));
+ guestNic.setIPv4Address(_ipAddrMgr.acquireFirstGuestIpAddress(guestNetwork));
Review comment:
@ArthurHlt should acquireGuestIpAddressForVrouterRedundant be used here as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services