You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/06 13:55:29 UTC
[GitHub] [maven-surefire] joergsesterhenn opened a new pull request #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
joergsesterhenn opened a new pull request #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274
As advised by @rfscholte and suggested by @Tibor17 I created this pull request to fix compatibility with maven 3.0.5 by replacing injection of LocationManager with instantiation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-605027159
@rfscholte
Do you expect any injection points in the class `LocationManager` (plexus-java)?
In the future?
Should it be a plain POJO?
Should it be a bean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-595977893
Have you tried to install (i.e. `mvn install -DskipTests`) this patch in your local repo? How does it work for you (i.e. `mvn -nsu test` on your own project)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-613969826
@michael-o
Let's post this on @dev and require deprecating the MVN 3.0.x.
We have couple of reasons (JSR330, component injection) why it should be deprecated version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609809334
I think the injection point should be moved from `SurefireMojo` to `SurefirePlugin` and `IntegrationTestMojo`. Try to add it in the POM in `surefire-common` , and if it does not work then it would mean that you have to move it directly to the module of every MOJO class. Let's see what will happen...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609798108
Unfortunately the Maven 3.0.x is not EOF yet, see the history:
http://maven.apache.org/docs/history.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] michael-o edited a comment on issue #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
michael-o edited a comment on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609800610
>
>
> Unfortunately the Maven 3.0.x is not EOF yet, see the history:
> http://maven.apache.org/docs/history.html
This is one of our serious problems I have raised on dev@ some months ago. We have no please policy how long something is support officially or at best effort. 7 years old release are more than enough.
@joergsesterhenn Can you tell why you still rely on it? Old product?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609805463
@joergsesterhenn
I have checked the code. Surefire does not generate `components.xml` using `plexus-component-metadata`. Pls rewrite the commit to generate this metadata file. I hope this would be the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] rfscholte commented on issue #274: SUREFIRE-1628
fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
rfscholte commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-608454907
I won't guarantee anything. Having it available as a bean gives me the freedom to inject other beans. So far there hasn't been a reason to do so.
I would suggest to try and get the LocationManager as bean. If it is null, create one yourself via the constructor. Once surefire requires Maven 3.1, you can drop the null-check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] eolivelli commented on issue #274: SUREFIRE-1628
fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609789999
Don't know sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 edited a comment on issue #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609809334
I think the injection point should be moved from `SurefireMojo` to `SurefirePlugin` and `IntegrationTestMojo`. Try to add it in the POM in `maven-surefire-common` , and if it does not work then it would mean that you have to move it directly to the module of every MOJO class. Let's see what will happen...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609749317
@eolivelli
@rfscholte
Do you think that it helps if we generate `component.xml` via `plexus-component-metadata:generate-metadata` in Maven 3.0.5? If we do not use JSR-330 in the MOJO, and we use Component annotation then this can be fixed by generating the `component.xml`. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] joergsesterhenn commented on issue #274:
SUREFIRE-1628 fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
joergsesterhenn commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609779188
We do currently. Would have been nice to see this working in 3.0.5. If this
is a big issue please see to it that at least the compatibility level is
documented and implemented correctly for surefire. And maybe announce 3.0.5
as EOL. TIA Jörg
Michael Osipov <no...@github.com> schrieb am Mo., 6. Apr. 2020,
14:02:
> I'd go the simplest route: require 3.1 for Surefire 3.x
> @joergsesterhenn <https://github.com/joergsesterhenn> Do you rely on
> Maven 3.0.x?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/maven-surefire/pull/274#issuecomment-609751803>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHN6SS7DXKKATPTGYCZMLDRLHAF3ANCNFSM4LDAVNEQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] michael-o commented on issue #274: SUREFIRE-1628
fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609800610
>
>
> Unfortunately the Maven 3.0.x is not EOF yet, see the history:
> http://maven.apache.org/docs/history.html
This is one of our serious problems I have raised on dev@ some months ago. We have no please policy how long something is support officially or at best effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-595977893
Have you tried to install (i.e. `mvn install -DskipTests`) this patch in your local repo? How does it work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] mosabua commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
mosabua commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-614314166
Totally agree with deprecating 3.0 .. in fact I would deprecate 3.1 and probably 3.2 as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-614652858
@mosabua
yes, I would doo it too, even 3.3.x as well. We have updated all plugins to 3.0 and it was not easy job. IMO doing it with 3.1 would be as simple as updating the dependencies only and much easier than before. If we would do it systemematically, we would deprecate also 3.2, I am sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609805463
@joergsesterhenn
I have checked the code. Surefire does not generate `components.xml` using `plexus-component-metadata`. Pls rewrite the commit to generate this metada file. I hope this would be the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #274: SUREFIRE-1628 fix
compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-608369136
@eolivelli
Robert mentioned this option of instantiating this `LocationManager` instead of injecting it.
If Robert guarantees that future versions wouldn't use injections in the class `LocationManager` then we are on the safe side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] michael-o commented on issue #274: SUREFIRE-1628
fix compatibility with maven 3.0.5
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #274: SUREFIRE-1628 fix compatibility with maven 3.0.5
URL: https://github.com/apache/maven-surefire/pull/274#issuecomment-609751803
I'd go the simplest route: require 3.1 for Surefire 3.x
@joergsesterhenn Do you rely on Maven 3.0.x?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services