You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by su...@apache.org on 2013/04/05 00:54:09 UTC
svn commit: r1464780 - in
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs: CHANGES.txt
src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java
Author: suresh
Date: Thu Apr 4 22:54:09 2013
New Revision: 1464780
URL: http://svn.apache.org/r1464780
Log:
HDFS-4625. Make TestNNWithQJM#testNewNamenodeTakesOverWriter work on Windows. Contributed by Ivan Mitic.
Modified:
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt?rev=1464780&r1=1464779&r2=1464780&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt Thu Apr 4 22:54:09 2013
@@ -346,6 +346,9 @@ Trunk (Unreleased)
HDFS-4604. TestJournalNode fails on Windows. (Ivan Mitic via suresh)
+ HDFS-4625. Make TestNNWithQJM#testNewNamenodeTakesOverWriter work on
+ Windows. (Ivan Mitic via suresh)
+
Release 2.0.5-beta - UNRELEASED
INCOMPATIBLE CHANGES
Modified: hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java?rev=1464780&r1=1464779&r2=1464780&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java (original)
+++ hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/TestNNWithQJM.java Thu Apr 4 22:54:09 2013
@@ -98,9 +98,6 @@ public class TestNNWithQJM {
@Test (timeout = 30000)
public void testNewNamenodeTakesOverWriter() throws Exception {
- // Skip the test on Windows. See HDFS-4584.
- assumeTrue(!Path.WINDOWS);
-
File nn1Dir = new File(
MiniDFSCluster.getBaseDirectory() + "/TestNNWithQJM/image-nn1");
File nn2Dir = new File(
@@ -110,23 +107,37 @@ public class TestNNWithQJM {
nn1Dir.getAbsolutePath());
conf.set(DFSConfigKeys.DFS_NAMENODE_EDITS_DIR_KEY,
mjc.getQuorumJournalURI("myjournal").toString());
-
+
+ // Start the cluster once to generate the dfs dirs
MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf)
.numDataNodes(0)
.manageNameDfsDirs(false)
.checkExitOnShutdown(false)
.build();
+ // Shutdown the cluster before making a copy of the namenode dir
+ // to release all file locks, otherwise, the copy will fail on
+ // some platforms.
+ cluster.shutdown();
+
try {
- cluster.getFileSystem().mkdirs(TEST_PATH);
-
// Start a second NN pointed to the same quorum.
// We need to copy the image dir from the first NN -- or else
// the new NN will just be rejected because of Namespace mismatch.
FileUtil.fullyDelete(nn2Dir);
FileUtil.copy(nn1Dir, FileSystem.getLocal(conf).getRaw(),
new Path(nn2Dir.getAbsolutePath()), false, conf);
-
+
+ // Start the cluster again
+ cluster = new MiniDFSCluster.Builder(conf)
+ .numDataNodes(0)
+ .format(false)
+ .manageNameDfsDirs(false)
+ .checkExitOnShutdown(false)
+ .build();
+
+ cluster.getFileSystem().mkdirs(TEST_PATH);
+
Configuration conf2 = new Configuration();
conf2.set(DFSConfigKeys.DFS_NAMENODE_NAME_DIR_KEY,
nn2Dir.getAbsolutePath());