[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1512: [HUDI-763] Add hoodie.table.base.file.format option to hoodie.properties file

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #1512:
URL: https://github.com/apache/incubator-hudi/pull/1512#discussion_r411783820



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFileFormat.java
##########
@@ -22,7 +22,7 @@
  * Hoodie file format.
  */
 public enum HoodieFileFormat {
-  PARQUET(".parquet"), HOODIE_LOG(".log");
+  PARQUET(".parquet"), HOODIE_LOG(".log"), ORC(".orc");

Review comment:
       again, this can happen in a PR, that actually adds ORC support.. not now ?>

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -190,6 +190,9 @@ public Operation convert(String value) throws ParameterException {
     @Parameter(names = {"--table-type"}, description = "Type of table. COPY_ON_WRITE (or) MERGE_ON_READ", required = true)
     public String tableType;
 
+    @Parameter(names = {"--table-file-format"}, description = "BaseFileFormat of table. PARQUET (or) ORC")

Review comment:
       adding something like this without actual ORC support feel bit premature and misleading to me.. for e,g if we release the code in few weeks, deltastreams help will be very misleading.. let's wait till we have datasource or some level of progress with ORC atleast ? 

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java
##########
@@ -251,6 +252,8 @@ public void validate(String name, String value) {
     public String tableName = null;
     @Parameter(names = {"--table-type", "-tt"}, description = "Table type", required = true)
     public String tableType = null;
+    @Parameter(names = {"--table-file-format", "-tff"}, description = "The base file storage format")

Review comment:
       same here.. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org