You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2019/02/01 01:41:12 UTC
Review Request 69877: ATLAS-3043: added unique-attributes constraints
at store-level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69877/
-----------------------------------------------------------
Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3043
https://issues.apache.org/jira/browse/ATLAS-3043
Repository: atlas
Description
-------
- updated type-creation to create a shade-property for unique-attribute at the store-level, along with unique-constraint
- updated entity create/update to set above shade-propety in the entity vertex
- updated entity delete to remove shade-property from the deleted entity vertex
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 1b507840e
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 74f73b441
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 8170e1b24
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java 69d3f63f9
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 967b052d5
Diff: https://reviews.apache.org/r/69877/diff/1/
Testing
-------
- verified that all unit-tests and ITs pass
- verified manually via Hive create/delete/create of a table, to ensure that shade-property is updated correctly.
Thanks,
Madhan Neethiraj
Re: Review Request 69877: ATLAS-3043: added unique-attributes
constraints at store-level
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69877/#review212510
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 31, 2019, 5:41 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69877/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2019, 5:41 p.m.)
>
>
> Review request for atlas, Abhishek Kadam, Ashutosh Mestry, keval bhatt, Kapildeo Nayak, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3043
> https://issues.apache.org/jira/browse/ATLAS-3043
>
>
> Repository: atlas
>
>
> Description
> -------
>
> - updated type-creation to create a shade-property for unique-attribute at the store-level, along with unique-constraint
> - updated entity create/update to set above shade-propety in the entity vertex
> - updated entity delete to remove shade-property from the deleted entity vertex
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 1b507840e
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 74f73b441
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 8170e1b24
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java 69d3f63f9
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 967b052d5
>
>
> Diff: https://reviews.apache.org/r/69877/diff/1/
>
>
> Testing
> -------
>
> - verified that all unit-tests and ITs pass - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/912
> - verified manually via Hive create/delete/create of a table, to ensure that shade-property is updated correctly.
>
>
> Thanks,
>
> Madhan Neethiraj
>
>