You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "John Lee (Created) (JIRA)" <ji...@apache.org> on 2011/11/18 00:41:51 UTC
[jira] [Created] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
----------------------------------------------------------------------------------------------------------------------------
Key: HADOOP-7833
URL: https://issues.apache.org/jira/browse/HADOOP-7833
Project: Hadoop Common
Issue Type: Bug
Reporter: John Lee
Priority: Blocker
findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
* SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
* SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
* UCF_USELESS_CONTROL_FLOW: Useless control flow
This can be fixed by adding the following findbugs exclude filter:
+ <Match>
+ <!-- protobuf generated code -->
+ <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
+ </Match>
which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7833:
-----------------------------
Attachment: HADOOP-7833.patch
Removed the findbugs filter match for org.apache.hadoop.ipc.protobuf.HadoopRpcProtos, as requested by Suresh Srinivas.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7833:
-----------------------------
Status: Patch Available (was: Open)
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154213#comment-13154213 ]
Hudson commented on HADOOP-7833:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #870 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/870/])
HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153175#comment-13153175 ]
John Lee commented on HADOOP-7833:
----------------------------------
Hi Suresh,
Updated the filter to only match the inner classes now.
Thanks for taking a look at this.
John
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154049#comment-13154049 ]
John Lee commented on HADOOP-7833:
----------------------------------
Cool, thanks Suresh!
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7833:
-----------------------------
Attachment: HADOOP-7833.patch
Added a findbugs filter to exclude inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154166#comment-13154166 ]
Hudson commented on HADOOP-7833:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #904 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/904/])
HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7833:
-------------------------------------------
Component/s: ipc
Fix Version/s: 0.23.3
I have merged this to 0.23.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7833:
-----------------------------
Status: Patch Available (was: Open)
Probably will still get -1 due to -1 javadoc, but no Java code was introduced in this patch.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Lee updated HADOOP-7833:
-----------------------------
Status: Open (was: Patch Available)
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7833:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I committed the patch. Thank you John.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154017#comment-13154017 ]
Hudson commented on HADOOP-7833:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1370 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1370/])
HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7833:
------------------------------------
Priority: Major (was: Blocker)
Target Version/s: 0.24.0
Fix Version/s: 0.24.0
Assignee: John Lee
Hadoop Flags: Reviewed
+1 for the patch.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154019#comment-13154019 ]
Hudson commented on HADOOP-7833:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1296 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1296/])
HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154039#comment-13154039 ]
Hudson commented on HADOOP-7833:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1320 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1320/])
HADOOP-7833. Fix findbugs warnings in protobuf generated code. Contributed by John Lee.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1204363
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Assignee: John Lee
> Fix For: 0.24.0
>
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153192#comment-13153192 ]
Hadoop QA commented on HADOOP-7833:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504275/HADOOP-7833.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/385//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/385//console
This message is automatically generated.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch, HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153158#comment-13153158 ]
Suresh Srinivas commented on HADOOP-7833:
-----------------------------------------
John, thanks for doing this. The warnings were introduced by me :-)
Can you remove the previous section, where I had tried to suppress these warnings (that did not work).
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152479#comment-13152479 ]
Hadoop QA commented on HADOOP-7833:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504144/HADOOP-7833.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/382//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/382//console
This message is automatically generated.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7833) Inner classes of
org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings
which results in -1 for findbugs
Posted by "John Lee (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152560#comment-13152560 ]
John Lee commented on HADOOP-7833:
----------------------------------
In response to:
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
This patch does not have any new or modified tests because it was modifying a findbugs filter file. It was tested by running mvn compile findbugs:findbugs in the hadoop-common-project sub-directory and I verified by examining hadoop-common/target/findbugsXml.xml file for the absence of any org.apache.hadoop.ipc.protobuf.HadoopRpcProtos related warnings. Additionally, this build received a +1 findbugs indicating the absence of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos related warnings.
The -1 javadocs is an issue which is unrelated to this patch, as no Java code was updated.
> Inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos generates findbugs warnings which results in -1 for findbugs
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7833
> URL: https://issues.apache.org/jira/browse/HADOOP-7833
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: John Lee
> Priority: Blocker
> Attachments: HADOOP-7833.patch
>
>
> findbugs reports the following medium priority warnings for some inner class in the generated class ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java:
> * SE_BAD_FIELD_STORE: Non-serializable value stored into instance field of a serializable class
> * SE_BAD_FIELD: Non-transient non-serializable instance field in serializable class
> * UCF_USELESS_CONTROL_FLOW: Useless control flow
> This can be fixed by adding the following findbugs exclude filter:
> + <Match>
> + <!-- protobuf generated code -->
> + <Class name="~org\.apache\.hadoop\.ipc\.protobuf\.HadoopRpcProtos.*"/>
> + </Match>
> which will exclude all inner classes of org.apache.hadoop.ipc.protobuf.HadoopRpcProtos
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira