[GitHub] stevedlawrence commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #84: Daffodil 1923 - Allow use of the same character for escapeBlockEnd and escapeEscapeCharacter
URL: https://github.com/apache/incubator-daffodil/pull/84#discussion_r203449901
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/dfa/Rules.scala
 ##########
 @@ -501,6 +503,11 @@ class EECStateBlock(states: => ArrayBuffer[State], blockEnd: DFADelimiter, val E
         r.nextState = StartState
       }
     },
+    Rule { (r: Registers) => couldBeFirstChar(r.data0, blockEnd) } {
+      (r: Registers) => {
+        r.status = StateKind.Paused //PTERMState
+      }
+    },
 
 Review comment:
   Can you clarify why this change is needed. I can't say if it's write or wrong, but seems odd that this changes it to check data1 first before data0. Does this instead need a change similar to the above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services