You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by marijan milicevic <m....@onehippo.com> on 2012/03/02 15:31:45 UTC

Review Request: RAVE-375: Create user from Admin interface

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4155/
-----------------------------------------------------------

Review request for rave.


Summary
-------

Create user from Admin interface


Diffs
-----

  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1296220 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1296220 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/newaccount.jsp PRE-CREATION 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/users.jsp 1296220 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp PRE-CREATION 
  https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1296220 

Diff: https://reviews.apache.org/r/4155/diff


Testing
-------


Thanks,

marijan

Re: Review Request: RAVE-375: Create user from Admin interface

Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4155/#review5560
-----------------------------------------------------------



https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java
<https://reviews.apache.org/r/4155/#comment12030>

    Missing unit test, I'll add one



https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java
<https://reviews.apache.org/r/4155/#comment12031>

    More missing unit tests, I'll add them



https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp
<https://reviews.apache.org/r/4155/#comment12029>

    The license header is missing, I'll add the correct one


- Jasha


On 2012-03-02 14:31:45, marijan milicevic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4155/
> -----------------------------------------------------------
> 
> (Updated 2012-03-02 14:31:45)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> Create user from Admin interface
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/newaccount.jsp PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/users.jsp 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1296220 
> 
> Diff: https://reviews.apache.org/r/4155/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> marijan
> 
>

Re: Review Request: RAVE-375: Create user from Admin interface

Posted by Jasha Joachimsthal <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4155/#review5565
-----------------------------------------------------------

Ship it!


Added unit tests, missing label and license header. Thanks for the patch Marijan and have a nice weekend!

- Jasha


On 2012-03-02 14:31:45, marijan milicevic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4155/
> -----------------------------------------------------------
> 
> (Updated 2012-03-02 14:31:45)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> Create user from Admin interface
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/controller/admin/UserController.java 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/util/ViewNames.java 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/newaccount.jsp PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/users.jsp 1296220 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/includes/new_user_form.jsp PRE-CREATION 
>   https://svn.apache.org/repos/asf/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1296220 
> 
> Diff: https://reviews.apache.org/r/4155/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> marijan
> 
>