You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Brock Noland <br...@cloudera.com> on 2014/08/20 20:48:02 UTC
Review Request 24903: HIVE-7682: HadoopThriftAuthBridge20S should not
reset configuration unless required
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24903/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
Described in JIRA
Diffs
-----
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 8b9da7a
Diff: https://reviews.apache.org/r/24903/diff/
Testing
-------
Thanks,
Brock Noland
Re: Review Request 24903: HIVE-7682: HadoopThriftAuthBridge20S should
not reset configuration unless required
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24903/#review52060
-----------------------------------------------------------
Looks fine, a couple of minor comments/suggestions below.
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/24903/#comment90796>
I am not sure if this will compile for hadoop 0.20 profile, otherwise you might need a shim wrapper for getLoginUser()
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java
<https://reviews.apache.org/r/24903/#comment90795>
Perhaps we can change pass the AuthenticationMethod directly from the caller to make this simpler.
- Prasad Mujumdar
On Aug. 20, 2014, 6:48 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24903/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 6:48 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Described in JIRA
>
>
> Diffs
> -----
>
> shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 8b9da7a
>
> Diff: https://reviews.apache.org/r/24903/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 24903: HIVE-7682: HadoopThriftAuthBridge20S should
not reset configuration unless required
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24903/#review52073
-----------------------------------------------------------
Ship it!
LGTM
- Prasad Mujumdar
On Sept. 2, 2014, 7:50 p.m., Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24903/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 7:50 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Described in JIRA
>
>
> Diffs
> -----
>
> shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 8b9da7a
>
> Diff: https://reviews.apache.org/r/24903/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Brock Noland
>
>
Re: Review Request 24903: HIVE-7682: HadoopThriftAuthBridge20S should
not reset configuration unless required
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24903/
-----------------------------------------------------------
(Updated Sept. 2, 2014, 7:50 p.m.)
Review request for hive.
Changes
-------
Attached is latest patch.
Hi,
Technically I don't think 0.20 is supported:
http://mail-archives.apache.org/mod_mbox/hive-dev/201403.mbox/%3CCAENxBwy3FGVLr4FO-swQn2yOjw40MFGdx1wzqAnfD_1Z5EXftg@mail.gmail.com%3E
however, changing the method to "cleanup" the string -> enum stuff requires a bunch of changes in the build to remove 0.20 support. Thus for this patch I don't think we should clean that up.
Repository: hive-git
Description
-------
Described in JIRA
Diffs (updated)
-----
shims/common-secure/src/main/java/org/apache/hadoop/hive/thrift/HadoopThriftAuthBridge20S.java 8b9da7a
Diff: https://reviews.apache.org/r/24903/diff/
Testing
-------
Thanks,
Brock Noland