[jira] [Comment Edited] (THRIFT-3669) JS Deserialization of lists of lists is broken

["Jared Szechy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137669#comment-16137669 ] 

Jared Szechy edited comment on THRIFT-3669 at 8/23/17 12:25 AM:
----------------------------------------------------------------

If it helps I cleaned up the previous patch (removed syntax formatting) and updated it for v0.10.0.

[^THRIFT-3669-0.10.0.pach]


was (Author: szechyjs):
If it helps I cleaned up the previous patch (removed syntax formatting) and updated it for v0.10.0.


> JS Deserialization of lists of lists is broken
> ----------------------------------------------
>
>                 Key: THRIFT-3669
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3669
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.9.3
>            Reporter: Christian Bürckert
>         Attachments: 0001-Fixed-THRIFT-3669.patch, THRIFT-3669-0.10.0.pach, thrift.js
>
>
> struct QueryResult {
> 	1: required list<list<string>> rows;
> }
> service QueryService{
> 	QueryResult query(); 
> }
> Using TJSONProtocol the list<list<string>> is transmitted correctly but deserialized wrong. Only the first sublist will contain the correct string values the second, third and so on will be empty. The error is a combination of readListBegin, readListEnd and readString (in thrift.js) which somehow interacts wrongly with the internal rstack when lists are included in lists. 
> As a temporary solution until the deserialization is fixed I advice others to create an intermediate struct which contains the sublists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)