You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/07 11:21:49 UTC
[GitHub] [camel] orpiske opened a new pull request #4380: Replaces the kafka container in camel-kafka test
orpiske opened a new pull request #4380:
URL: https://github.com/apache/camel/pull/4380
Switches to the infra provided by camel-test-infra-kafka instead of
directly using the KafkaContainer.
This removes the need of camel-testcontainers-junit5 and allows
targetting remote kafka instances as part of the test execution.
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #4380: Replaces the kafka container in camel-kafka test
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #4380:
URL: https://github.com/apache/camel/pull/4380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4380: Replaces the kafka container in camel-kafka test
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4380:
URL: https://github.com/apache/camel/pull/4380#issuecomment-704870591
@lburgazzoli @oscerd @davsclaus this is related to previous discussions in the mailing list about the test-infra.
Among other things, this could serves as a quick reference about how to use the code from those modules.
Changing to the test infra also brings one additional test feature: it's possible to target remote deployments of Kafka.
```mvn -Dkafka.instance.type=remote -Dkafka.bootstrap.servers=myserver:9092 clean test verify```
wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org