You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/05/16 04:31:09 UTC
[shardingsphere] branch master updated: Fix sonar issue of SQLServerSchemaMetaDataLoader (#25692)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new dc2ec8cde0d Fix sonar issue of SQLServerSchemaMetaDataLoader (#25692)
dc2ec8cde0d is described below
commit dc2ec8cde0da548c98ed313acfe4bba098b63607
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Tue May 16 12:31:02 2023 +0800
Fix sonar issue of SQLServerSchemaMetaDataLoader (#25692)
* Fix sonar issue of SQLServerSchemaMetaDataLoader
* Fix sonar issue of SQLServerSchemaMetaDataLoader
* Fix sonar issue of SQLServerSchemaMetaDataLoader
---
.../schema/loader/metadata/dialect/SQLServerSchemaMetaDataLoader.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/dialect/SQLServerSchemaMetaDataLoader.java b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/dialect/SQLServerSchemaMetaDataLoader.java
index bfa6071084b..606327e973e 100644
--- a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/dialect/SQLServerSchemaMetaDataLoader.java
+++ b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/dialect/SQLServerSchemaMetaDataLoader.java
@@ -102,7 +102,7 @@ public final class SQLServerSchemaMetaDataLoader implements DialectSchemaMetaDat
String collationName = resultSet.getString("COLLATION_NAME");
boolean primaryKey = "1".equals(resultSet.getString("IS_PRIMARY_KEY"));
boolean generated = "1".equals(resultSet.getString("IS_IDENTITY"));
- boolean caseSensitive = null != collationName && collationName.indexOf("_CS") > 0;
+ boolean caseSensitive = null != collationName && collationName.contains("_CS");
boolean isVisible = !(versionContainsHiddenColumn(databaseMetaData) && "1".equals(resultSet.getString("IS_HIDDEN")));
return new ColumnMetaData(columnName, dataTypeMap.get(dataType), primaryKey, generated, caseSensitive, isVisible, false);
}