You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/08 12:48:00 UTC
[jira] [Commented] (FLINK-8604) Move JobTerminationHandler to
WebMonitorEndpoint
[ https://issues.apache.org/jira/browse/FLINK-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356899#comment-16356899 ]
ASF GitHub Bot commented on FLINK-8604:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5429
[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
## What is the purpose of the change
Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.
## Verifying this change
- Tested manually
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink moveTerminationHandler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5429
----
commit 216876ae1d3fd0509bd5591576d9d4c960c1aa80
Author: Till Rohrmann <tr...@...>
Date: 2018-02-06T18:11:53Z
[hotfix] Change shutdown order in WebMonitorEndpoint to avoid illegal state
commit f906423456b0f42c46213584b91d7c75321289c5
Author: Till Rohrmann <tr...@...>
Date: 2018-02-08T12:43:09Z
[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.
----
> Move JobTerminationHandler to WebMonitorEndpoint
> ------------------------------------------------
>
> Key: FLINK-8604
> URL: https://issues.apache.org/jira/browse/FLINK-8604
> Project: Flink
> Issue Type: Improvement
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{JobTerminationHandler}} is currently only registered in the {{DispatcherRestEndpoint}}. However, it should also be possible to terminate jobs from the web UI. In order to support this, the {{JobTerminationHandler}} has to be registered at the {{WebMonitorEndpoint}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)