Move from Travis to GitHub Actions

[sebb <se...@gmail.com>]

I have set up a couple of GH Actions to replace the Travis jobs.

These seem to be working OK finally after a lot of false starts.

Note that the screen navigation tests have to be skipped, as they were
on Travis.
This is because chromedriver crashes, which appears to be because GH
runs headless.
I've not been able to find out how to fix this, but at least the same
set of tests now run under GH, so I have renamed the Travis file to
switch it off.

Sebb

Re: Move from Travis to GitHub Actions

[Sam Ruby <ru...@intertwingly.net>]

On Tue, Mar 29, 2022 at 12:57 PM sebb <se...@gmail.com> wrote:
>
> AFAICT the navigate test does not use the Vue server, so I assume the
> problem must be somewhere in Capybara/Puma/Selenium.
>
> So it would be useful to enable some tracing for those.

Agreed.

Meanwhile, some random thoughts:

1) The hex address stack traceback shown in the current log is useless.
2) The error message that we do have implies some sort of server failure.
3) The test in question is a client test.  No specific server
functionality is being called for here beyond what is exercised in
other tests.
4) The indication is that the error is occurring on a HTTP get request.

Net: none of this makes sense.  The test also passes for me on my
laptop - other than hanging at the end as I have a newer version of
node installed.

On *THAT* topic, I don't presume that the underlying issue is an API
change, but rather node not knowing when to quit.  Essentially JS is
an event driven language where you write code that waits for events.
Programs exit only when node is sure that no possible future events
can ever take place.  Something in node's heuristics must have
changed.

This all works out much better - at least it is easier to reason
about, if the client and server are written in the same language.  But
that doesn't seem meant to be - at least not here at the ASF.

I guess my recommendation is to not enable that one test, and leave
that problem to the infra team.

- Sam Ruby



> On Tue, 29 Mar 2022 at 16:05, sebb <se...@gmail.com> wrote:
> >
> > It looks as though chromedriver is working under GHA, as a test does
> > work against apache.org.
> >
> > However as soon as the test script tries to check the content of an
> > agenda page, it fails:
> >
> > https://github.com/apache/whimsy/runs/5739402171?check_suite_focus=true
> >
> > Any ideas?
> >
> > Sebb
> >
> > On Fri, 25 Mar 2022 at 23:46, sebb <se...@gmail.com> wrote:
> > >
> > > On Fri, 25 Mar 2022 at 23:35, sebb <se...@gmail.com> wrote:
> > > >
> > > > On Fri, 25 Mar 2022 at 23:13, Sam Ruby <ru...@intertwingly.net> wrote:
> > > > >
> > > > > On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
> > > > > >
> > > > > > I have set up a couple of GH Actions to replace the Travis jobs.
> > > > >
> > > > > Excellent!
> > > > >
> > > > > > These seem to be working OK finally after a lot of false starts.
> > > > > >
> > > > > > Note that the screen navigation tests have to be skipped, as they were
> > > > > > on Travis.
> > > > > > This is because chromedriver crashes, which appears to be because GH
> > > > > > runs headless.
> > > > > > I've not been able to find out how to fix this, but at least the same
> > > > > > set of tests now run under GH, so I have renamed the Travis file to
> > > > > > switch it off.
> > > > >
> > > > > Have you tried https://github.com/marketplace/actions/setup-chromedriver ?
> > > >
> > > > I have now.
> > > > The software is already installed, so I just used the run commands,
> > > > and that has solved the issue for Ubuntu, but the driver still crashes
> > > > on macOS.
> > > > It would probably be OK to skip the test on macOS if that cannot be solved.
> > > > It's anyway an improvement on the previous setup.
> > >
> > > Unfortunately although the driver no longer crashes on Ubuntu, the
> > > navigation test does not work.
> > >
> > > > Thanks!
> > > >
> > > > > > Sebb
> > > > >
> > > > > - Sam Ruby

Re: Move from Travis to GitHub Actions

[sebb <se...@gmail.com>]

AFAICT the navigate test does not use the Vue server, so I assume the
problem must be somewhere in Capybara/Puma/Selenium.

So it would be useful to enable some tracing for those.

On Tue, 29 Mar 2022 at 16:05, sebb <se...@gmail.com> wrote:
>
> It looks as though chromedriver is working under GHA, as a test does
> work against apache.org.
>
> However as soon as the test script tries to check the content of an
> agenda page, it fails:
>
> https://github.com/apache/whimsy/runs/5739402171?check_suite_focus=true
>
> Any ideas?
>
> Sebb
>
> On Fri, 25 Mar 2022 at 23:46, sebb <se...@gmail.com> wrote:
> >
> > On Fri, 25 Mar 2022 at 23:35, sebb <se...@gmail.com> wrote:
> > >
> > > On Fri, 25 Mar 2022 at 23:13, Sam Ruby <ru...@intertwingly.net> wrote:
> > > >
> > > > On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
> > > > >
> > > > > I have set up a couple of GH Actions to replace the Travis jobs.
> > > >
> > > > Excellent!
> > > >
> > > > > These seem to be working OK finally after a lot of false starts.
> > > > >
> > > > > Note that the screen navigation tests have to be skipped, as they were
> > > > > on Travis.
> > > > > This is because chromedriver crashes, which appears to be because GH
> > > > > runs headless.
> > > > > I've not been able to find out how to fix this, but at least the same
> > > > > set of tests now run under GH, so I have renamed the Travis file to
> > > > > switch it off.
> > > >
> > > > Have you tried https://github.com/marketplace/actions/setup-chromedriver ?
> > >
> > > I have now.
> > > The software is already installed, so I just used the run commands,
> > > and that has solved the issue for Ubuntu, but the driver still crashes
> > > on macOS.
> > > It would probably be OK to skip the test on macOS if that cannot be solved.
> > > It's anyway an improvement on the previous setup.
> >
> > Unfortunately although the driver no longer crashes on Ubuntu, the
> > navigation test does not work.
> >
> > > Thanks!
> > >
> > > > > Sebb
> > > >
> > > > - Sam Ruby

Re: Move from Travis to GitHub Actions

[sebb <se...@gmail.com>]

It looks as though chromedriver is working under GHA, as a test does
work against apache.org.

However as soon as the test script tries to check the content of an
agenda page, it fails:

https://github.com/apache/whimsy/runs/5739402171?check_suite_focus=true

Any ideas?

Sebb

On Fri, 25 Mar 2022 at 23:46, sebb <se...@gmail.com> wrote:
>
> On Fri, 25 Mar 2022 at 23:35, sebb <se...@gmail.com> wrote:
> >
> > On Fri, 25 Mar 2022 at 23:13, Sam Ruby <ru...@intertwingly.net> wrote:
> > >
> > > On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
> > > >
> > > > I have set up a couple of GH Actions to replace the Travis jobs.
> > >
> > > Excellent!
> > >
> > > > These seem to be working OK finally after a lot of false starts.
> > > >
> > > > Note that the screen navigation tests have to be skipped, as they were
> > > > on Travis.
> > > > This is because chromedriver crashes, which appears to be because GH
> > > > runs headless.
> > > > I've not been able to find out how to fix this, but at least the same
> > > > set of tests now run under GH, so I have renamed the Travis file to
> > > > switch it off.
> > >
> > > Have you tried https://github.com/marketplace/actions/setup-chromedriver ?
> >
> > I have now.
> > The software is already installed, so I just used the run commands,
> > and that has solved the issue for Ubuntu, but the driver still crashes
> > on macOS.
> > It would probably be OK to skip the test on macOS if that cannot be solved.
> > It's anyway an improvement on the previous setup.
>
> Unfortunately although the driver no longer crashes on Ubuntu, the
> navigation test does not work.
>
> > Thanks!
> >
> > > > Sebb
> > >
> > > - Sam Ruby

Re: Move from Travis to GitHub Actions

[sebb <se...@gmail.com>]

On Fri, 25 Mar 2022 at 23:35, sebb <se...@gmail.com> wrote:
>
> On Fri, 25 Mar 2022 at 23:13, Sam Ruby <ru...@intertwingly.net> wrote:
> >
> > On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
> > >
> > > I have set up a couple of GH Actions to replace the Travis jobs.
> >
> > Excellent!
> >
> > > These seem to be working OK finally after a lot of false starts.
> > >
> > > Note that the screen navigation tests have to be skipped, as they were
> > > on Travis.
> > > This is because chromedriver crashes, which appears to be because GH
> > > runs headless.
> > > I've not been able to find out how to fix this, but at least the same
> > > set of tests now run under GH, so I have renamed the Travis file to
> > > switch it off.
> >
> > Have you tried https://github.com/marketplace/actions/setup-chromedriver ?
>
> I have now.
> The software is already installed, so I just used the run commands,
> and that has solved the issue for Ubuntu, but the driver still crashes
> on macOS.
> It would probably be OK to skip the test on macOS if that cannot be solved.
> It's anyway an improvement on the previous setup.

Unfortunately although the driver no longer crashes on Ubuntu, the
navigation test does not work.

> Thanks!
>
> > > Sebb
> >
> > - Sam Ruby

Re: Move from Travis to GitHub Actions

[sebb <se...@gmail.com>]

On Fri, 25 Mar 2022 at 23:13, Sam Ruby <ru...@intertwingly.net> wrote:
>
> On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
> >
> > I have set up a couple of GH Actions to replace the Travis jobs.
>
> Excellent!
>
> > These seem to be working OK finally after a lot of false starts.
> >
> > Note that the screen navigation tests have to be skipped, as they were
> > on Travis.
> > This is because chromedriver crashes, which appears to be because GH
> > runs headless.
> > I've not been able to find out how to fix this, but at least the same
> > set of tests now run under GH, so I have renamed the Travis file to
> > switch it off.
>
> Have you tried https://github.com/marketplace/actions/setup-chromedriver ?

I have now.
The software is already installed, so I just used the run commands,
and that has solved the issue for Ubuntu, but the driver still crashes
on macOS.
It would probably be OK to skip the test on macOS if that cannot be solved.
It's anyway an improvement on the previous setup.

Thanks!

> > Sebb
>
> - Sam Ruby

Re: Move from Travis to GitHub Actions

[Sam Ruby <ru...@intertwingly.net>]

On Fri, Mar 25, 2022 at 7:02 PM sebb <se...@gmail.com> wrote:
>
> I have set up a couple of GH Actions to replace the Travis jobs.

Excellent!

> These seem to be working OK finally after a lot of false starts.
>
> Note that the screen navigation tests have to be skipped, as they were
> on Travis.
> This is because chromedriver crashes, which appears to be because GH
> runs headless.
> I've not been able to find out how to fix this, but at least the same
> set of tests now run under GH, so I have renamed the Travis file to
> switch it off.

Have you tried https://github.com/marketplace/actions/setup-chromedriver ?

> Sebb

- Sam Ruby