You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/04/26 23:38:03 UTC
[jira] [Created] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Remove deprecated JobTracker.State in favour of JobTrackerStatus
----------------------------------------------------------------
Key: MAPREDUCE-2455
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Reporter: Tom White
Assignee: Tom White
Fix For: 0.23.0
MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057267#comment-13057267 ]
Hudson commented on MAPREDUCE-2455:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #722 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/722/])
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035014#comment-13035014 ]
Todd Lipcon commented on MAPREDUCE-2455:
----------------------------------------
Tom and I discussed this a bit. Although it's not clear whether we can remove everything deprecated in 0.22 yet, we think it's OK to remove this one for the following rationale:
- the API isn't commonly used (eg Pig doesn't use it at all and Hive uses it in just one place)
- the workaround to deal with the incompatibility is a trivial rename
- this is blocking MAPREDUCE-1638 which we really need to do sooner than later
So, +1
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2455:
---------------------------------
Attachment: MAPREDUCE-2455.patch
Here's a patch for this change.
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041657#comment-13041657 ]
Hudson commented on MAPREDUCE-2455:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #706 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/706/])
MAPREDUCE-2455. Remove deprecated JobTracker.State in favour of JobTrackerStatus.
tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1129771
Files :
* /hadoop/mapreduce/trunk/src/contrib/capacity-scheduler/src/test/org/apache/hadoop/mapred/CapacityTestUtils.java
* /hadoop/mapreduce/trunk/CHANGES.txt
* /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/FakeObjectUtilities.java
* /hadoop/mapreduce/trunk/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/ClusterStatus.java
* /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestJobQueueTaskScheduler.java
* /hadoop/mapreduce/trunk/src/webapps/job/jobtracker.jspx
* /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestParallelInitialization.java
* /hadoop/mapreduce/trunk/src/webapps/job/jobtracker.jsp
* /hadoop/mapreduce/trunk/src/test/mapred/org/apache/hadoop/mapred/TestJobInProgress.java
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobTracker.java
* /hadoop/mapreduce/trunk/src/java/org/apache/hadoop/mapred/JobClient.java
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2455:
---------------------------------
Status: Patch Available (was: Open)
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2455:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Incompatible change, Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this.
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026083#comment-13026083 ]
Todd Lipcon commented on MAPREDUCE-2455:
----------------------------------------
Since this was just deprecated in trunk, not 0.20, can we actually remove it yet?
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026095#comment-13026095 ]
Tom White commented on MAPREDUCE-2455:
--------------------------------------
The deprecation (MAPREDUCE-2337) will go into 0.22, and then I was hoping this could go into 0.23. Removing this method allows the division of API and implementation in MAPREDUCE-1638, which will be beneficial for MAPREDUCE-279, for example (which is targetted for 0.23, as I understand it).
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025530#comment-13025530 ]
Hadoop QA commented on MAPREDUCE-2455:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477443/MAPREDUCE-2455.patch
against trunk revision 1096649.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/187//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/187//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/187//console
This message is automatically generated.
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040353#comment-13040353 ]
Arun C Murthy commented on MAPREDUCE-2455:
------------------------------------------
I agree that we shud fix this for 23.
In fact, I'd go further and actually consider removing this api. The JT is always in RUNNING state (while not dead ;) ) and thus I don't see the utility of this api. Maybe Hive really doesn't need it?
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040479#comment-13040479 ]
Arun C Murthy commented on MAPREDUCE-2455:
------------------------------------------
+1 for doing this presently.
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2455) Remove deprecated
JobTracker.State in favour of JobTrackerStatus
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040367#comment-13040367 ]
Tom White commented on MAPREDUCE-2455:
--------------------------------------
> In fact, I'd go further and actually consider removing this api.
I agree with the sentiment. ClusterStatus shouldn't be used as a monitoring API, since metrics (or other monitoring systems) should be used for that purpose. In particular, the API that ClusterStatus (or ClusterMetrics in the new API) exposes doesn't fit with MAPREDUCE-279. It's premature to remove them in 0.23, but it makes sense to consider replacements for them.
Of course, we still need this JIRA to move forward with MAPREDUCE-1638 and the code organization for MAPREDUCE-279.
> Remove deprecated JobTracker.State in favour of JobTrackerStatus
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-2455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2455
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build, client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2455.patch
>
>
> MAPREDUCE-2337 deprecated getJobTrackerState() on ClusterStatus, this issue is to remove the getter (in favour of getJobTrackerStatus(), which will remain) so there is no longer a direct dependency of the public API on JobTracker. This is for MAPREDUCE-1638.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira