You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2006/07/14 11:36:29 UTC
[jira] Created: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
PATCH: Configurable language for SnowballPorterFilterFactory
------------------------------------------------------------
Key: SOLR-27
URL: http://issues.apache.org/jira/browse/SOLR-27
Project: Solr
Type: Improvement
Components: search
Reporter: Bertrand Delacretaz
Priority: Minor
With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
<filter class="solr.SnowballPorterFilterFactory" language="French"/>
Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=comments#action_12421538 ]
Bertrand Delacretaz commented on SOLR-27:
-----------------------------------------
>...it looks like the default language will be whatever was specified last time...
I don't think so - I haven't checked the lifecycle of these factories precisely, but I've used the same configuration pattern as in StopFilterFactory, for example.
If I use the following configurations in my schema.xml, each in its own <fieldtype>:
<filter class="solr.SnowballPorterFilterFactory" language="French" />
...
<filter class="solr.SnowballPorterFilterFactory" />
The log says
INFO: SnowballPorterFilterFactory: language=French
...
INFO: SnowballPorterFilterFactory: language=English
Which is what I expect.
Let me know if I missed something!
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=comments#action_12421622 ]
Yonik Seeley commented on SOLR-27:
----------------------------------
Oops, you're right. A new factory is created for each use in the schema.
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=all ]
Bertrand Delacretaz updated SOLR-27:
------------------------------------
Attachment: SnowballPorterFilterFactory.patch
The single souce file to patch
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.patch
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=comments#action_12421117 ]
Yonik Seeley commented on SOLR-27:
----------------------------------
In the case that the filter is used in a schema more than once, it looks like the default language will be whatever was specified last time (or "English" if first). Was that the intent?
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=all ]
Yonik Seeley resolved SOLR-27.
------------------------------
Resolution: Fixed
Assignee: Yonik Seeley
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Assigned To: Yonik Seeley
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=all ]
Bertrand Delacretaz updated SOLR-27:
------------------------------------
Attachment: SnowballPorterFilterFactory.java
Seems like the previous patch is invalid, dunno why, weird characters in the source file? or I'm doing something wrong.
Here's the new version just in case.
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SOLR-27) PATCH: Configurable language for
SnowballPorterFilterFactory
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/SOLR-27?page=comments#action_12421645 ]
Yonik Seeley commented on SOLR-27:
----------------------------------
Committed. Thanks Bertrand!
> PATCH: Configurable language for SnowballPorterFilterFactory
> ------------------------------------------------------------
>
> Key: SOLR-27
> URL: http://issues.apache.org/jira/browse/SOLR-27
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Bertrand Delacretaz
> Priority: Minor
> Attachments: SnowballPorterFilterFactory.java, SnowballPorterFilterFactory.patch
>
>
> With this patch, the language used by SnowballPorterFilterFactory is configurable, for example:
> <filter class="solr.SnowballPorterFilterFactory" language="French"/>
> Invalid languages will cause a ClassNotFoundException when the filter is created (so at search time possibly, not at initialization time).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira