[GitHub] [iceberg] singhpk234 commented on a diff in pull request #4825: Test: Fix flaky testOlderThanTimestamp in TestRemoveOrphanFilesAction3

[GitBox <gi...@apache.org>]

singhpk234 commented on code in PR #4825:
URL: https://github.com/apache/iceberg/pull/4825#discussion_r880867926


##########
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveOrphanFilesAction.java:
##########
@@ -420,7 +420,7 @@ public void testOlderThanTimestamp() throws InterruptedException {
 

Review Comment:
   +1, I also see `org.apache.iceberg.spark.actions.TestRemoveOrphanFilesAction3 > orphanedFileRemovedWithParallelTasks FAILED` has become flaky in master as well, 
   
   failed iceberg run : https://github.com/apache/iceberg/runs/6577825750?check_suite_focus=true
   
   I think we should sleep by atleast 1000 ms, to handle issue like these [StackOverflow](https://stackoverflow.com/questions/24804618/get-file-mtime-with-millisecond-resolution-from-java).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org