[jira] [Commented] (NIFI-4147) Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072922#comment-16072922 ] 

ASF GitHub Bot commented on NIFI-4147:
--------------------------------------

GitHub user peter-gergely-horvath opened a pull request:

    https://github.com/apache/nifi/pull/1972

    NIFI-4147 Class org.apache.nifi.bootstrap.RunNiFi is not designed wit…

    This pull request adds support described in [NIFI-4147
    Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind](https://issues.apache.org/jira/browse/NIFI-4147)
    
    NOTE: As of now, `-Pcontrib-check clean install` does fail in 
    nifi-assembly with the error _No formats specified in the execution parameters or the assembly descriptor._ but that should be unrelated to the change.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peter-gergely-horvath/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1972.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1972
    
----
commit 581874620684357445c69028a2aebedabb87e1c3
Author: Peter G. Horvath <pe...@gmail.com>
Date:   2017-07-03T21:19:45Z

    NIFI-4147 Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind

----


> Class org.apache.nifi.bootstrap.RunNiFi is not designed with extensibility in mind
> ----------------------------------------------------------------------------------
>
>                 Key: NIFI-4147
>                 URL: https://issues.apache.org/jira/browse/NIFI-4147
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>            Reporter: Peter Horvath
>
> Class org.apache.nifi.bootstrap.RunNiFi was not designed with extensibility in mind. This class is used to bootstrap the runtime; the current implementation does not support extending the class with different behaviour, that would be essential to bootstrap the engine within an integration test. 
> This class should be changed so that it can be easily subclassed, allowing it to be later extended within an integration test runner:
> * The verbose parameter within the RunNiFi constructor is not used: eliminate it
> * getBootstrapConfFile() is static, which means it cannot easily be overridden in a test stub: replace with an instance method, which can be overridden
> * Methods getPidFile, getStatusFile, getLockFile, getStatusFile are package protected, preventing these methods to be stubbed for an integration test: make them protected so that they can be overridden from a subclass (allowing an integration test runner to override default behaviour in a test run)
> *Please note these changes are baby-steps towards the implementation of a NiFi integration test harness.*



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)