You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/06 03:32:37 UTC
[GitHub] [inlong] gosonzhang opened a new pull request, #5792: [INLONG-5788][DataProxy] Incorrect readFailSize metric value
gosonzhang opened a new pull request, #5792:
URL: https://github.com/apache/inlong/pull/5792
- Fixes #5788
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5792: [INLONG-5788][DataProxy] Fix the incorrect readFailSize metric value
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5792:
URL: https://github.com/apache/inlong/pull/5792#discussion_r963293298
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/TubeSink.java:
##########
@@ -285,7 +285,7 @@ public Status process() throws EventDeliveryException {
cachedMsgCnt.incrementAndGet();
DataProxyMetricItem metricItem = this.metricItemSet.findMetricItem(dimensions);
metricItem.readSuccessCount.incrementAndGet();
- metricItem.readFailSize.addAndGet(event.getBody().length);
+ metricItem.readSuccessSize.addAndGet(event.getBody().length);
} else {
tx.rollback();
//logger.info("[{}] Channel --> Queue(has no enough space,current code point) "
Review Comment:
Could you please remove those unused log codes at the same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5792: [INLONG-5788][DataProxy] Fix the incorrect readFailSize metric value
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5792:
URL: https://github.com/apache/inlong/pull/5792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #5792: [INLONG-5788][DataProxy] Fix the incorrect readFailSize metric value
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #5792:
URL: https://github.com/apache/inlong/pull/5792#discussion_r963300201
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/TubeSink.java:
##########
@@ -285,7 +285,7 @@ public Status process() throws EventDeliveryException {
cachedMsgCnt.incrementAndGet();
DataProxyMetricItem metricItem = this.metricItemSet.findMetricItem(dimensions);
metricItem.readSuccessCount.incrementAndGet();
- metricItem.readFailSize.addAndGet(event.getBody().length);
+ metricItem.readSuccessSize.addAndGet(event.getBody().length);
} else {
tx.rollback();
//logger.info("[{}] Channel --> Queue(has no enough space,current code point) "
Review Comment:
I see a lot of such useless comments and codes. It is better to submit a separate issue to solve it.
@healchow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org