You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/10/06 18:32:28 UTC
[kudu-CR] [webui] Add templates for master web ui.
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8227
Change subject: [webui] Add templates for master web ui.
......................................................................
[webui] Add templates for master web ui.
This adds templates to the rest of the master webui endpoints for which
it makes sense:
- /tablet-servers
- /masters
Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
A www/masters.mustache
M www/tables.mustache
A www/tablet-servers.mustache
5 files changed, 184 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8227/1
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8227
to look at the new patch set (#2).
Change subject: [webui] Add templates for master web ui.
......................................................................
[webui] Add templates for master web ui.
This adds templates to the rest of the master webui endpoints for which
it makes sense:
- /tablet-servers
- /masters
Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
A www/masters.mustache
M www/tables.mustache
A www/tablet-servers.mustache
5 files changed, 184 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8227/2
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8227 )
Change subject: [webui] Add templates for master web ui.
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@94
PS2, Line 94: Substit
std::to_string() should work here
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@123
PS2, Line 123: has_no_live_ts = desc->PresumedDead() && has_no_live_ts;
: has_no_dead_ts = !desc->PresumedDead() && has_no_dead_ts
can use &= here
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@126
PS2, Line 126: (*output)["has_no_live_ts"] = "true";
: if (has_no_dead_ts) (*output)["has_no_dead_ts"] = "true";
how about using = std::to_string(has_no_live_ts)? would something like that work? we must have some nice way to do a bool-to-string
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 13 Oct 2017 00:23:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8227 )
Change subject: [webui] Add templates for master web ui.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 17 Oct 2017 04:36:22 +0000
Gerrit-HasComments: No
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8227 )
Change subject: [webui] Add templates for master web ui.
......................................................................
[webui] Add templates for master web ui.
This adds templates to the rest of the master webui endpoints for which
it makes sense:
- /tablet-servers
- /masters
Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Reviewed-on: http://gerrit.cloudera.org:8080/8227
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
A www/masters.mustache
M www/tables.mustache
A www/tablet-servers.mustache
5 files changed, 184 insertions(+), 93 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8227
to look at the new patch set (#3).
Change subject: [webui] Add templates for master web ui.
......................................................................
[webui] Add templates for master web ui.
This adds templates to the rest of the master webui endpoints for which
it makes sense:
- /tablet-servers
- /masters
Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/master/master-path-handlers.h
A www/masters.mustache
M www/tables.mustache
A www/tablet-servers.mustache
5 files changed, 184 insertions(+), 93 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8227/3
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [webui] Add templates for master web ui.
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8227 )
Change subject: [webui] Add templates for master web ui.
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@94
PS2, Line 94: std::to
> std::to_string() should work here
Done
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@123
PS2, Line 123: has_no_live_ts &= desc->PresumedDead();
: has_no_dead_ts &= !desc->PresumedDead();
> can use &= here
Done
http://gerrit.cloudera.org:8080/#/c/8227/2/src/kudu/master/master-path-handlers.cc@126
PS2, Line 126: ive_ts"] = has_no_live_ts;
: (*output)["has_no_dead_ts"] = has_no_dead_ts;
> how about using = std::to_string(has_no_live_ts)? would something like that
Done
--
To view, visit http://gerrit.cloudera.org:8080/8227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4520261dd617a160da51cdd089f42f078a0da728
Gerrit-Change-Number: 8227
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 16 Oct 2017 05:58:51 +0000
Gerrit-HasComments: Yes