You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/04 03:37:05 UTC
[GitHub] [spark] zhengruifeng commented on issue #26124:
[SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component
zhengruifeng commented on issue #26124: [SPARK-29224][ML]Implement Factorization Machines as a ml-pipeline component
URL: https://github.com/apache/spark/pull/26124#issuecomment-561462028
> I still doubt whether existing testsuite is enough.
1, I suggest to add several testsuites to check whether FMClassifier and FMRegressor can learn the intercept correctly.
Like '// Test if we can correctly learn Y = 0.1 + 1.2X1 - 1.3X2 + 20X1X2' in https://github.com/apache/spark/pull/5591/files
For example, we generate Y=Y = 0.1 + 1.2 X1 - 1.3 X2 + 20 X1 X2, and we can check whether 20 * X1 * X2 can be learned by checking dot(V1, V2) ~== 20.
2, I suggest to add some testcases with fitBias==false or/and fitLinear==false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org