You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/11 08:59:52 UTC

[GitHub] [incubator-superset] graceguo-supercat commented on issue #8521: [WIP][dashboard scoped filter] part 2: add algorithm to convert checked ids to scope object

graceguo-supercat commented on issue #8521: [WIP][dashboard scoped filter] part 2: add algorithm to convert checked ids to scope object
URL: https://github.com/apache/incubator-superset/pull/8521#issuecomment-552352236
 
 
   I just realized I messed up this PR with some commits in another PR. so i rebased it again. This PR should only contain changes for the function that converts checked chart ids to scope object (and its unit test).
   
   For the comments about filter scope selector, I fixed them in #8404.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org