You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xy720 (via GitHub)" <gi...@apache.org> on 2023/04/22 18:13:36 UTC
[GitHub] [doris] xy720 opened a new pull request, #18935: [bug](map-type)fix some bugs in map and map element function
xy720 opened a new pull request, #18935:
URL: https://github.com/apache/doris/pull/18935
# Proposed changes
fix some bugs in map and map element function:
1、error occur when map constructor's parameter is empty:
Before:
```
mysql> select map();
ERROR 1105 (HY000): errCode = 2, detailMessage = Unexpected exception: 0
```
After:
```
mysql> SELECT map();
+-------+
| MAP{} |
+-------+
| MAP{} |
+-------+
1 row in set (0.01 sec)
```
2、be core in map constructor when the parameter number is odd:
Before
```
mysql> select map(1,'a',3,'c',5);
ERROR 1105 (HY000): RpcException, msg: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason
```
After
```
mysql> select map(1,'a',3,'c',5);
ERROR 1105 (HY000): errCode = 2, detailMessage = map can't be odd parameters, need even parameters: map(1, 2, 3, 4, 5)
```
3、be core in map element function
Before
```
mysql> select {1:"a", 3:"b", 5:"c"}[1];
ERROR 1105 (HY000): RpcException, msg: org.apache.doris.rpc.RpcException: io.grpc.StatusRuntimeException: UNAVAILABLE: Network closed for unknown reason
```
After
```
mysql> select {1:"a", 3:"b", 5:"c"}[1];
+------------------------------------------------+
| %element_extract%(MAP{1:'a', 3:'b', 5:'c'}, 1) |
+------------------------------------------------+
| a |
+------------------------------------------------+
1 row in set (0.02 sec)
```
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1523371693
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1523371610
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1519051707
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.66 seconds
stream load tsv: 432 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230423120942_clickbench_pr_133414.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518720994
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1519045245
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518721346
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518936091
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518931542
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518935729
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518720538
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 merged pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 merged PR #18935:
URL: https://github.com/apache/doris/pull/18935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1519045810
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1519346013
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518720970
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #18935: [bug](map-type)fix some bugs in map and map element function
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on PR #18935:
URL: https://github.com/apache/doris/pull/18935#issuecomment-1518928687
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org