You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/01/23 19:15:23 UTC

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19864#discussion_r163347494
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ---
    @@ -60,7 +62,8 @@ case class InMemoryRelation(
         @transient child: SparkPlan,
         tableName: Option[String])(
         @transient var _cachedColumnBuffers: RDD[CachedBatch] = null,
    -    val batchStats: LongAccumulator = child.sqlContext.sparkContext.longAccumulator)
    +    val batchStats: LongAccumulator = child.sqlContext.sparkContext.longAccumulator,
    +    statsOfPlanToCache: Statistics = null)
    --- End diff --
    
    Why we set this to `null`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org