You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Gerhard Petracek <ge...@gmail.com> on 2011/12/18 01:58:00 UTC
[VOTE] coding conventions (DELTASPIKE-12)
Hi,
I asked [1] to add alternative settings to DELTASPIKE-12, since we have
seen several different opinions (about details).
Nobody added an alternative set. So I start the formal vote with the
suggested set right now.
If we don't see a majority, we have to re-visit this topic again (+ we
would need a new vote with at least one concrete alternative).
Please review the coding conventions at [2] and vote.
(Its content is also included below for your convenience).
------------------------------------------------
[ ] +1 I'm ok with the coding conventions
[ ] +0
[ ] -1 I've major objections, because...
------------------------------------------------
The vote is open for 72 hours.
Thanks,
Gerhard
[1] http://s.apache.org/Ga8
[2] http://s.apache.org/SAj
---
1) no tabs, only spaces (4 spaces).
2) bracelets on new line
3) force bracelets
4) 4 spaces indent size
5) a space between keyword and round bracket
6) a space before and after an operand
7) line width: 120
8) no underscore at the beginning
9) no wildcard imports
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Jakob Korherr <ja...@gmail.com>.
+1
Regards,
Jakob
2011/12/18 Marius Bogoevici <ma...@gmail.com>:
> +0: agree on the conventions, but I believe that we should expand with provisions about import structure:
>
> a) provision of 'no unused imports'
> b) provisions on import ordering e.g requesting something like:
>
> import statics;
>
> import java....;
>
> import javax......;
>
> import others;
>
> import org.deltaspike;
>
> Note that actual structure would be TBD, this is just a suggestion. The benefit to have a well-established import structure is that it further minimizes diffs introduced by various ways of adding imports (autocomplete, auto-import, manual, etc).
>
> On 2011-12-17, at 7:58 PM, Gerhard Petracek wrote:
>
>> Hi,
>>
>> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
>> seen several different opinions (about details).
>> Nobody added an alternative set. So I start the formal vote with the
>> suggested set right now.
>> If we don't see a majority, we have to re-visit this topic again (+ we
>> would need a new vote with at least one concrete alternative).
>>
>> Please review the coding conventions at [2] and vote.
>> (Its content is also included below for your convenience).
>>
>> ------------------------------------------------
>> [ ] +1 I'm ok with the coding conventions
>> [ ] +0
>> [ ] -1 I've major objections, because...
>> ------------------------------------------------
>>
>> The vote is open for 72 hours.
>>
>> Thanks,
>> Gerhard
>>
>> [1] http://s.apache.org/Ga8
>> [2] http://s.apache.org/SAj
>>
>> ---
>>
>> 1) no tabs, only spaces (4 spaces).
>> 2) bracelets on new line
>> 3) force bracelets
>> 4) 4 spaces indent size
>> 5) a space between keyword and round bracket
>> 6) a space before and after an operand
>> 7) line width: 120
>> 8) no underscore at the beginning
>> 9) no wildcard imports
>
--
Jakob Korherr
blog: http://www.jakobk.com
twitter: http://twitter.com/jakobkorherr
work: http://www.irian.at
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Marius Bogoevici <ma...@gmail.com>.
+0: agree on the conventions, but I believe that we should expand with provisions about import structure:
a) provision of 'no unused imports'
b) provisions on import ordering e.g requesting something like:
import statics;
import java....;
import javax......;
import others;
import org.deltaspike;
Note that actual structure would be TBD, this is just a suggestion. The benefit to have a well-established import structure is that it further minimizes diffs introduced by various ways of adding imports (autocomplete, auto-import, manual, etc).
On 2011-12-17, at 7:58 PM, Gerhard Petracek wrote:
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Antoine Sabot-Durand <an...@sabot-durand.net>.
+1
Antoine SABOT-DURAND
Le 18 déc. 2011 à 01:58, Gerhard Petracek a écrit :
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by "John D. Ament" <jo...@gmail.com>.
+1
On Sat, Dec 17, 2011 at 7:58 PM, Gerhard Petracek <
gerhard.petracek@gmail.com> wrote:
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
>
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Christian Kaltepoth <ch...@kaltepoth.de>.
+1 (non-binding)
2011/12/18 Jason Porter <li...@gmail.com>:
> +1
>
> On Sat, Dec 17, 2011 at 17:58, Gerhard Petracek
> <ge...@gmail.com>wrote:
>
>> +1
>>
>> regards,
>> gerhard
>>
>>
>>
>> 2011/12/18 Gerhard Petracek <ge...@gmail.com>
>>
>> > Hi,
>> >
>> > I asked [1] to add alternative settings to DELTASPIKE-12, since we have
>> > seen several different opinions (about details).
>> > Nobody added an alternative set. So I start the formal vote with the
>> > suggested set right now.
>> > If we don't see a majority, we have to re-visit this topic again (+ we
>> > would need a new vote with at least one concrete alternative).
>> >
>> > Please review the coding conventions at [2] and vote.
>> > (Its content is also included below for your convenience).
>> >
>> > ------------------------------------------------
>> > [ ] +1 I'm ok with the coding conventions
>> > [ ] +0
>> > [ ] -1 I've major objections, because...
>> > ------------------------------------------------
>> >
>> > The vote is open for 72 hours.
>> >
>> > Thanks,
>> > Gerhard
>> >
>> > [1] http://s.apache.org/Ga8
>> > [2] http://s.apache.org/SAj
>> >
>> > ---
>> >
>> > 1) no tabs, only spaces (4 spaces).
>> > 2) bracelets on new line
>> > 3) force bracelets
>> > 4) 4 spaces indent size
>> > 5) a space between keyword and round bracket
>> > 6) a space before and after an operand
>> > 7) line width: 120
>> > 8) no underscore at the beginning
>> > 9) no wildcard imports
>> >
>>
>
>
>
> --
> Jason Porter
> http://lightguard-jp.blogspot.com
> http://twitter.com/lightguardjp
>
> Software Engineer
> Open Source Advocate
> Author of Seam Catch - Next Generation Java Exception Handling
>
> PGP key id: 926CCFF5
> PGP key available at: keyserver.net, pgp.mit.edu
--
Christian Kaltepoth
Blog: http://chkal.blogspot.com/
Twitter: http://twitter.com/chkal
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Jason Porter <li...@gmail.com>.
+1
On Sat, Dec 17, 2011 at 17:58, Gerhard Petracek
<ge...@gmail.com>wrote:
> +1
>
> regards,
> gerhard
>
>
>
> 2011/12/18 Gerhard Petracek <ge...@gmail.com>
>
> > Hi,
> >
> > I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> > seen several different opinions (about details).
> > Nobody added an alternative set. So I start the formal vote with the
> > suggested set right now.
> > If we don't see a majority, we have to re-visit this topic again (+ we
> > would need a new vote with at least one concrete alternative).
> >
> > Please review the coding conventions at [2] and vote.
> > (Its content is also included below for your convenience).
> >
> > ------------------------------------------------
> > [ ] +1 I'm ok with the coding conventions
> > [ ] +0
> > [ ] -1 I've major objections, because...
> > ------------------------------------------------
> >
> > The vote is open for 72 hours.
> >
> > Thanks,
> > Gerhard
> >
> > [1] http://s.apache.org/Ga8
> > [2] http://s.apache.org/SAj
> >
> > ---
> >
> > 1) no tabs, only spaces (4 spaces).
> > 2) bracelets on new line
> > 3) force bracelets
> > 4) 4 spaces indent size
> > 5) a space between keyword and round bracket
> > 6) a space before and after an operand
> > 7) line width: 120
> > 8) no underscore at the beginning
> > 9) no wildcard imports
> >
>
--
Jason Porter
http://lightguard-jp.blogspot.com
http://twitter.com/lightguardjp
Software Engineer
Open Source Advocate
Author of Seam Catch - Next Generation Java Exception Handling
PGP key id: 926CCFF5
PGP key available at: keyserver.net, pgp.mit.edu
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Gerhard Petracek <ge...@gmail.com>.
+1
regards,
gerhard
2011/12/18 Gerhard Petracek <ge...@gmail.com>
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
>
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Mark Struberg <st...@yahoo.de>.
+1
LieGrue,
strub
----- Original Message -----
> From: Gerhard Petracek <ge...@gmail.com>
> To: deltaspike-dev@incubator.apache.org
> Cc:
> Sent: Sunday, December 18, 2011 1:58 AM
> Subject: [VOTE] coding conventions (DELTASPIKE-12)
>
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
>
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Mark Struberg <st...@yahoo.de>.
+1
LieGrue,
strub
----- Original Message -----
> From: Matthias Wessendorf <ma...@apache.org>
> To: deltaspike-dev@incubator.apache.org
> Cc:
> Sent: Monday, December 19, 2011 7:11 PM
> Subject: Re: [VOTE] coding conventions (DELTASPIKE-12)
>
> +1
>
> On Sun, Dec 18, 2011 at 1:58 AM, Gerhard Petracek
> <ge...@gmail.com> wrote:
>> Hi,
>>
>> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
>> seen several different opinions (about details).
>> Nobody added an alternative set. So I start the formal vote with the
>> suggested set right now.
>> If we don't see a majority, we have to re-visit this topic again (+ we
>> would need a new vote with at least one concrete alternative).
>>
>> Please review the coding conventions at [2] and vote.
>> (Its content is also included below for your convenience).
>>
>> ------------------------------------------------
>> [ ] +1 I'm ok with the coding conventions
>> [ ] +0
>> [ ] -1 I've major objections, because...
>> ------------------------------------------------
>>
>> The vote is open for 72 hours.
>>
>> Thanks,
>> Gerhard
>>
>> [1] http://s.apache.org/Ga8
>> [2] http://s.apache.org/SAj
>>
>> ---
>>
>> 1) no tabs, only spaces (4 spaces).
>> 2) bracelets on new line
>> 3) force bracelets
>> 4) 4 spaces indent size
>> 5) a space between keyword and round bracket
>> 6) a space before and after an operand
>> 7) line width: 120
>> 8) no underscore at the beginning
>> 9) no wildcard imports
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Matthias Wessendorf <ma...@apache.org>.
+1
On Sun, Dec 18, 2011 at 1:58 AM, Gerhard Petracek
<ge...@gmail.com> wrote:
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [VOTE] coding conventions (DELTASPIKE-12)
Posted by Shane Bryzak <sb...@gmail.com>.
+1
On Sun, Dec 18, 2011 at 10:58 AM, Gerhard Petracek <
gerhard.petracek@gmail.com> wrote:
> Hi,
>
> I asked [1] to add alternative settings to DELTASPIKE-12, since we have
> seen several different opinions (about details).
> Nobody added an alternative set. So I start the formal vote with the
> suggested set right now.
> If we don't see a majority, we have to re-visit this topic again (+ we
> would need a new vote with at least one concrete alternative).
>
> Please review the coding conventions at [2] and vote.
> (Its content is also included below for your convenience).
>
> ------------------------------------------------
> [ ] +1 I'm ok with the coding conventions
> [ ] +0
> [ ] -1 I've major objections, because...
> ------------------------------------------------
>
> The vote is open for 72 hours.
>
> Thanks,
> Gerhard
>
> [1] http://s.apache.org/Ga8
> [2] http://s.apache.org/SAj
>
> ---
>
> 1) no tabs, only spaces (4 spaces).
> 2) bracelets on new line
> 3) force bracelets
> 4) 4 spaces indent size
> 5) a space between keyword and round bracket
> 6) a space before and after an operand
> 7) line width: 120
> 8) no underscore at the beginning
> 9) no wildcard imports
>