[GitHub] [apisix-dashboard] moonming commented on pull request #619: feat: added e2e test for Login page

[GitBox <gi...@apache.org>]

moonming commented on pull request #619:
URL: https://github.com/apache/apisix-dashboard/pull/619#issuecomment-720274180


   you can refer to https://github.com/apache/apisix/blob/master/Makefile
   
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   litesun <no...@github.com> 于2020年11月2日周一 下午2:43写道：
   
   > *@LiteSun* commented on this pull request.
   > ------------------------------
   >
   > In frontend/src/e2e/README.md
   > <https://github.com/apache/apisix-dashboard/pull/619#discussion_r515766019>
   > :
   >
   > > +#     http://www.apache.org/licenses/LICENSE-2.0
   > +#
   > +# Unless required by applicable law or agreed to in writing, software
   > +# distributed under the License is distributed on an "AS IS" BASIS,
   > +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   > +# See the License for the specific language governing permissions and
   > +# limitations under the License.
   > +#
   > +-->
   > +
   > +### Writing test cases
   > +
   > +1. Install dependencies then run in development mode
   > +
   > +```sh
   > +$ yarn install && yarn start
   >
   > How about we use makefile to run test cases? In this way, developers only
   > need to know the entry of make.
   >
   > We can implement this separately later.
   >
   > Good idea, but I'm not familiar with makefile and need time to research
   > it. If that's OK, I'll use it in the future.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/pull/619#discussion_r515766019>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBKY2ANV2XMA5AUN3ZZ3SNZIIJANCNFSM4TDCRUBA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org