You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/08/22 16:32:38 UTC
Review Request 24980: [FALCON-632] Refactoring, documentation stuff
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24980/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Makes code more attractive
Diffs
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 1973bf8
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java ff227d6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e7b2616
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 119d871
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fc8e4a8
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 85bd770
Diff: https://reviews.apache.org/r/24980/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk
Re: Review Request 24980: [FALCON-632] Refactoring,
documentation stuff
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24980/#review51312
-----------------------------------------------------------
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java
<https://reviews.apache.org/r/24980/#comment89493>
process should probably be made a method local variable, becasue it is being reassigned in every method.
- Raghav Gautam
On Aug. 22, 2014, 7:32 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24980/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2014, 7:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Makes code more attractive
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 1973bf8
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java ff227d6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e7b2616
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 119d871
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fc8e4a8
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 85bd770
>
> Diff: https://reviews.apache.org/r/24980/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 24980: [FALCON-632] Refactoring,
documentation stuff
Posted by Raghav Gautam <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24980/#review51536
-----------------------------------------------------------
Ship it!
Ship It!
- Raghav Gautam
On Aug. 26, 2014, 3:37 a.m., Paul Isaychuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24980/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 3:37 a.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Makes code more attractive
>
>
> Diffs
> -----
>
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 1973bf8
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java ff227d6
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e7b2616
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 119d871
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fc8e4a8
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 85bd770
>
> Diff: https://reviews.apache.org/r/24980/diff/
>
>
> Testing
> -------
>
> tested
>
>
> Thanks,
>
> Paul Isaychuk
>
>
Re: Review Request 24980: [FALCON-632] Refactoring,
documentation stuff
Posted by Paul Isaychuk <pi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24980/
-----------------------------------------------------------
(Updated Aug. 26, 2014, 10:37 a.m.)
Review request for Falcon.
Changes
-------
process was made method local variable in ProcessInstanceRerunTest
Repository: falcon-git
Description
-------
Makes code more attractive
Diffs (updated)
-----
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/EmbeddedPigScriptTest.java 1973bf8
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedInstanceStatusTest.java ff227d6
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e7b2616
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceRerunTest.java 119d871
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLibPathTest.java fc8e4a8
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/prism/RetentionTest.java 85bd770
Diff: https://reviews.apache.org/r/24980/diff/
Testing
-------
tested
Thanks,
Paul Isaychuk