You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/10/10 11:42:44 UTC
[jira] Created: (QPID-1344) low level refactoring for replay breaks
protocol negotiation
low level refactoring for replay breaks protocol negotiation
------------------------------------------------------------
Key: QPID-1344
URL: https://issues.apache.org/jira/browse/QPID-1344
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: M4
Reporter: Martin Ritchie
Fix For: M4
Summary:
The change in QPID-1339 is causing Protocol negotiation to fail.
Problem
The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1344) low level refactoring for replay breaks
protocol negotiation
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1344:
---------------------------------
Component/s: (was: Java Broker)
Java Common
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Common
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rafael H. Schloming
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1344) low level refactoring for replay
breaks protocol negotiation
Posted by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rafael H. Schloming resolved QPID-1344.
---------------------------------------
Resolution: Fixed
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Common
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rafael H. Schloming
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1344) low level refactoring for replay
breaks protocol negotiation
Posted by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638628#action_12638628 ]
Rafael H. Schloming commented on QPID-1344:
-------------------------------------------
My clever cloning plot didn't quite work because Throwable doesn't permit you to overwrite the initial cause once it is set, however I submitted something that is reasonably equivalent.
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Common
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rafael H. Schloming
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1344) low level refactoring for replay
breaks protocol negotiation
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1344:
------------------------------------
Assignee: Martin Ritchie
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (QPID-1344) low level refactoring for replay
breaks protocol negotiation
Posted by "Rafael H. Schloming (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638541#action_12638541 ]
Rafael H. Schloming commented on QPID-1344:
-------------------------------------------
I'd prefer wrapping rather than rethrowing. I think it's confusing when an exception from one thread is rethrown in another thread since the stack traces don't match up. It was my bad though not checking that I hadn't broken version negotiation beofre committing on QPID-1339, so I'll reassign to myself and play with some other options. I have a vague idea that cloning the original exception and then reinitializing the stack trace and initial cause might result in generic way to create an exception that preserves the stack traces from both threads, but doesn't require the handling code to do a DFS through a linked chain of exceptions in order to get to the detail associated with the originating chain of exceptions.
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Common
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rafael H. Schloming
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1344) low level refactoring for replay
breaks protocol negotiation
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie reassigned QPID-1344:
------------------------------------
Assignee: Rafael H. Schloming (was: Martin Ritchie)
Hi Rafi, is this change good? The alternative was to check in the 0-10 delegate for a ProtocolVersionException cause in the ConnectionException, but seemed cleaner to throw the PVE earlier.
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rafael H. Schloming
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1344) low level refactoring for replay breaks
protocol negotiation
Posted by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Ritchie updated QPID-1344:
---------------------------------
Status: Ready To Review (was: In Progress)
> low level refactoring for replay breaks protocol negotiation
> ------------------------------------------------------------
>
> Key: QPID-1344
> URL: https://issues.apache.org/jira/browse/QPID-1344
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Martin Ritchie
> Fix For: M4
>
>
> Summary:
> The change in QPID-1339 is causing Protocol negotiation to fail.
> Problem
> The initial problem is that the check for protocol 0-10 in ClientDelegate was incorrect preventing the ProtocolVersionException from being propogated to the connection.
> The new Connection class also wraps the ProtocolVersionException so AMQConnection is unable to work out the new protocol to try so it continues to try 0-10 until failover is exhausted.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.