You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by Corentin Chary <co...@gmail.com> on 2017/09/20 12:38:15 UTC
Presubmit checks in github
Hello,
Looks like currently we don't automatically run any check when a new
pull request is created on github.
It could be as simple as
https://github.com/criteo-forks/cassandra/blob/cassandra-3.11-criteo/.travis.yml
(minus the release part)
I guess circleci could be used too since apparently it's already used
for some things.
Thoughs ?
--
Corentin Chary
http://xf.iksaif.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Presubmit checks in github
Posted by Corentin Chary <co...@gmail.com>.
I guess adding a hook for circle would work as well :)
On Wed, Sep 20, 2017 at 5:04 PM, Jeff Jirsa <jj...@gmail.com> wrote:
> At one point we tested with a travis config very similar to what circle does (run all the unit tests, etc). The free options for Travis can’t run the basic unit test suite reliably, where circle could, so we put the circle yaml in - no reason we can’t ADD Travis as well
>
> The ASF has a paid Travis account so we can get some basic builds and badges on pull request, but I’m not convinced we’ll ever get reliable unit test runs based on conversations with their (Travis) sales team, so the Travis badges wouldn’t really be meaningful.
>
> Some of us are actively working on making this less friction for contributors (by making test builds trigger on pull requests), but it takes time to get all that sorted out.
>
>
>
> --
> Jeff Jirsa
>
>
>> On Sep 20, 2017, at 5:38 AM, Corentin Chary <co...@gmail.com> wrote:
>>
>> Hello,
>> Looks like currently we don't automatically run any check when a new
>> pull request is created on github.
>>
>> It could be as simple as
>> https://github.com/criteo-forks/cassandra/blob/cassandra-3.11-criteo/.travis.yml
>> (minus the release part)
>>
>> I guess circleci could be used too since apparently it's already used
>> for some things.
>>
>> Thoughs ?
>>
>> --
>> Corentin Chary
>> http://xf.iksaif.net
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
>> For additional commands, e-mail: dev-help@cassandra.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
--
Corentin Chary
http://xf.iksaif.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: Presubmit checks in github
Posted by Jeff Jirsa <jj...@gmail.com>.
At one point we tested with a travis config very similar to what circle does (run all the unit tests, etc). The free options for Travis can’t run the basic unit test suite reliably, where circle could, so we put the circle yaml in - no reason we can’t ADD Travis as well
The ASF has a paid Travis account so we can get some basic builds and badges on pull request, but I’m not convinced we’ll ever get reliable unit test runs based on conversations with their (Travis) sales team, so the Travis badges wouldn’t really be meaningful.
Some of us are actively working on making this less friction for contributors (by making test builds trigger on pull requests), but it takes time to get all that sorted out.
--
Jeff Jirsa
> On Sep 20, 2017, at 5:38 AM, Corentin Chary <co...@gmail.com> wrote:
>
> Hello,
> Looks like currently we don't automatically run any check when a new
> pull request is created on github.
>
> It could be as simple as
> https://github.com/criteo-forks/cassandra/blob/cassandra-3.11-criteo/.travis.yml
> (minus the release part)
>
> I guess circleci could be used too since apparently it's already used
> for some things.
>
> Thoughs ?
>
> --
> Corentin Chary
> http://xf.iksaif.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
> For additional commands, e-mail: dev-help@cassandra.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org