You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/28 19:16:52 UTC
[GitHub] [camel-k-runtime] lburgazzoli opened a new pull request #511: kamelet source/sink component
lburgazzoli opened a new pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511
Fixes #490
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511#issuecomment-700493555
@nicolaferraro whith this PR, using `direct:{{routeId}}` won't be supported anymore and willr br replaced by `kamelet:source` and `kamelet:sink`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] davsclaus commented on pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511#issuecomment-700424947
Yeah @lburgazzoli that is a good idea, if you got the time this morning then you are welcome to fix that - I am in the middle of simple language improvements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511#issuecomment-700426631
@davsclaus sure I will do it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli merged pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511#issuecomment-700231222
@davsclaus I've merged your PR and it works fine, thx for your support
Wonder if to have better control over the route template creation process we should add a consumer to the `CamelContext::addRouteFromTemplate` that is invoked with the result of `RouteTemplateDefinition::asRouteDefinition` so we can hack the resulting route definition i.e. replace the in/out like in your solution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-runtime] lburgazzoli commented on pull request #511: kamelet source/sink component
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on pull request #511:
URL: https://github.com/apache/camel-k-runtime/pull/511#issuecomment-700585910
@davsclaus opened https://github.com/apache/camel/pull/4313, it is slightly different from the proposal as the definitions are not part of the APIs thus I can't add something meaningful to the camel context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org